Prevent CPU HLO profiling crashes - #103
Open
stevenvar wants to merge 1 commit into
Open
Conversation
stevenvar
force-pushed
the
steven.cpu_hlo_profile_fix
branch
from
July 30, 2026 10:41
16b72a3 to
1a3aa6c
Compare
stevenvar
force-pushed
the
steven.cpu_hlo_profile_fix
branch
from
July 30, 2026 10:43
1a3aa6c to
76586bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash when using
--xla_hlo_profile=truewith XLA:CPU.Before this change, XLA could generate profiling code, but at runtime the profiling counter buffer could be missing. The generated code then tried to write to a null pointer and crashed.
This change:
On non-x86 CPUs, it also uses a safer runtime timer instead of a low-level LLVM cycle counter.