Skip to content

Add support for the XDG Base Directory Specification. - #292

Open
denisfa wants to merge 1 commit into
joeyespo:masterfrom
denisfa:xdg-base-dir-spec-support
Open

Add support for the XDG Base Directory Specification.#292
denisfa wants to merge 1 commit into
joeyespo:masterfrom
denisfa:xdg-base-dir-spec-support

Conversation

@denisfa

@denisfa denisfa commented Apr 19, 2019

Copy link
Copy Markdown

Hey @joeyespo.

This is a fix for #286. We adopt the solution as given by the table in this comment. The order of precedence is:

  1. ${GRIPHOME}/settings.py (if GRIPHOME is set)
  2. ~/.grip/settings.py (if ~/.grip exists)
  3. ${XDG_CONFIG_HOME:-~/.config}/grip/settings.py (fallback)

Also, the cache files are in ${XDG_CACHE_HOME:-~/.cache}/grip. I believe these files are not important at all for the user, hence I decided to not have a migration path for them.

Feel free to comment whatever you want about this.

@alichtman

Copy link
Copy Markdown

Hey @joeyespo, any update on this PR?

@shinenelson

Copy link
Copy Markdown

almost another year later, here is another person showing interest and support for this pull request to be merged. I checked this pull request ref out and tried it. It worked as expected for me. Can we please merge this pull request? I do not see any issues that is blocking it.

@alichtman

alichtman commented Jun 19, 2022

Copy link
Copy Markdown

Hey @joeyespo, can you merge this?

@toh995

toh995 commented Jun 20, 2022

Copy link
Copy Markdown

I'd love to see this merged as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants