Sort "Recent entries" for water

[janraasch]

Solves #2

---

context

Hi @joemasilotti, nice to meet you 🤝. I came across this repo by way of your latest newsletter. I am in the process of writing a Rails x Tailwind x Turbo-app myself, so I decided to dig into the source code here a little bit. The help wanted-issues are great to solve some issues while looking around the code base.

solution

The sorting happens on the ruby-level (i.e. using sort_by). This way we do not have to cross the #amount-abstraction level implemented by measured-rails. Performance-wise - I think - it's okay, since we'll have to load the three WaterEntrys from the db for rendering the view anyway, so we might as well do the sorting after loading everything from the db.

I added two clean up-type commits on top.

Let me know what you think.

Kind regards from Germany 🇩🇪,
Jan

[joemasilotti]

Thanks for the PR! And I'm excited to see what you build with Turbo Native.

Unfortunately adding this sort doesn't change the underlying problem - the query is still returning duplicate entries. I just pushed a failing test to show what I mean. Let me know if that doesn't make sense!

[janraasch]

Hi @joemasilotti, having a failing test case for #7 is great 👍.

I pushed (what I proposed on #7) 7c85026 which fixes the test case:

bin/rails test test/models/water_entry_tests.rb
Running 1 tests in a single process (parallelization threshold is 50)
Run options: --seed 63187

# Running:

.

Finished in 0.073761s, 13.5573 runs/s, 13.5573 assertions/s.
1 runs, 1 assertions, 0 failures, 0 errors, 0 skips

However, if I understand your comment here correctly, this is not what you want to have.

Could you add another failing test to detail the expected behaviour further 🙏?

Test driven-feature-specification 😇 😉 ☺️.

Have an amazing Pre-Christmas weekend 🎄👋,
Jan