added expect nothing in default specs - #78
Open
kaashan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When we configure failSpecWithNoExpectations to true in karma.conf.js file and run selected tests, the test
failSpecWithNoExpectations to true in jasmine and karma-parallel add the extra tests #71
What is the new behavior (if this is a feature change)?
Running karma-parallel with selected tests won't cause overall test failure as the default tests added by karma-parallel have been configured to perform an assertion (by calling expect().nothing();)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: