macOS Developer ID signing + notarization in CI#1
Merged
Conversation
…lback When SIGN_IDENTITY is set, sign the binary with hardened runtime, the audio- input entitlement, and a secure timestamp (the prerequisites for notarization and for a Gatekeeper-clean install), then seal the bundle. Without it, keep the ad-hoc path for local dev. Adds scripts/holler.entitlements.
Import the Developer ID cert into a throwaway keychain, pass SIGN_IDENTITY to the bundler (hardened-runtime Developer ID signing), then notarize the DMG with notarytool and staple the ticket. All steps are gated on their secrets, so builds without the secrets configured fall back to the existing ad-hoc path and stay green.
Add docs/SIGNING.md (Developer ID cert, the six GitHub secrets and where to get each, release + local flows). Update the README signing note and the DECISIONS distribution row to point at it.
The 'secrets' context isn't allowed in step if: conditions (caused an immediate workflow-validation failure). Surface the signing secrets as job-level env and gate the import/notarize steps on env.* instead.
The signing secrets are stored as Environment secrets (env 'ENV'); a job only sees them if it opts into that environment. Add environment: ENV to the universal-DMG job so the cert import + notarization steps can read them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires Developer ID signing + Apple notarization into the release pipeline so the macOS DMG installs without a Gatekeeper warning for everyone (and the Accessibility/Mic grants stop resetting on rebuild).
Changes
Validation
Tested on a branch push with the real secrets: cert import, Developer ID signing, notarization, and stapling all succeeded (after accepting the pending Apple Developer agreement). Build green on macOS arm64+x64+universal and Windows x64.
Merging this, then tagging `v0.1.1`, produces the first signed + notarized release.