Design OAuth core extraction boundary - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/oauthcoreextraction boundaryoauthproxyreverse-proxy behavior/authorizeoperator-only by defaultReviewer Guide
Context
This PR prepares the OAuth extraction work required before
hugo-public-mcpcan integrate optional OAuth safely. It is deliberately a design PR only: the implementation remains in issue #6 after review.Key decisions
internal/oauthcoreboundary, not a new public module.oauthproxyas the HTTP/reverse-proxy adapter.oauthcore./authorizeoperator-only by default.hugo-public-mcpin this extraction step.Intentionally not implemented
/authorizemode.Reviewer focus
oauthcoreboundary is small enough to extract incrementally.Risks
oauthcorewould make reuse byhugo-public-mcpbrittle.Related issue
Related to #6. This PR should not close #6; the implementation work remains open after design review.
Validation
go test ./...gitleaks detect --no-banner --redact --source .Production impact
Design only. No runtime behavior change, no production deployment, no tag, no release.