Fix CI integration test failures#16
Merged
Merged
Conversation
Two breakages in the integration test steps: 1. `pip install -U pymodbus` pulls pymodbus 3.x, which removed `pymodbus.server.sync` and `ModbusBinaryFramer`. server.py crashes on import, leaving the modbus client step to time out against a port nothing is listening on. Pin to pymodbus<3 so the existing server.py still imports, and pin Python to 3.11 since pymodbus 2.5.3 has not been validated against newer interpreters. 2. Servers are backgrounded with `&` and the next step runs the client immediately, racing the listen socket. Add explicit wait-for-port steps using bash's /dev/tcp before each client runs, and capture server output to /tmp logs so a failure surfaces diagnostics instead of just timing out. Also `nohup` the backgrounded servers and redirect their output so they survive the step boundary cleanly without printing into the runner log mid-step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two breakages in the integration test steps:
pip install -U pymodbuspulls pymodbus 3.x, which removedpymodbus.server.syncandModbusBinaryFramer. server.py crasheson import, leaving the modbus client step to time out against a
port nothing is listening on. Pin to pymodbus<3 so the existing
server.py still imports, and pin Python to 3.11 since pymodbus
2.5.3 has not been validated against newer interpreters.
Servers are backgrounded with
&and the next step runs theclient immediately, racing the listen socket. Add explicit
wait-for-port steps using bash's /dev/tcp before each client
runs, and capture server output to /tmp logs so a failure surfaces
diagnostics instead of just timing out.
Also
nohupthe backgrounded servers and redirect their output sothey survive the step boundary cleanly without printing into the
runner log mid-step.