Skip to content

feat(terminals): set PI WEB shell environment#58

Merged
jmfederico merged 4 commits into
jmfederico:mainfrom
ongspxm:feat_addtermflag
Jul 14, 2026
Merged

feat(terminals): set PI WEB shell environment#58
jmfederico merged 4 commits into
jmfederico:mainfrom
ongspxm:feat_addtermflag

Conversation

@ongspxm

@ongspxm ongspxm commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Sets PI_WEB_TERMINAL=1 for all shells opened in PI WEB terminals, including continued interactive shells.

This lets users run shell startup scripts only inside PI WEB terminals, for example:

if [ "$PI_WEB_TERMINAL" = "1" ]; then
  # Run PI WEB terminal setup here
fi

Testing

  • PI_WEB_TERMINAL=1 npm test -- --run src/server/terminals/terminalService.test.ts
  • npm run typecheck
  • npx eslint src/server/terminals/terminalService.ts src/server/terminals/terminalService.test.ts
  • npm run verify
  • npm run build
  • npm run pack:dry

@ongspxm ongspxm force-pushed the feat_addtermflag branch from 6b7b445 to 73ac24c Compare July 14, 2026 13:21
@jmfederico jmfederico merged commit a857fe4 into jmfederico:main Jul 14, 2026
@jmfederico

Copy link
Copy Markdown
Owner

Thanks for the contribution. Merged! 🎉

Before merging, I made a few focused adjustments:

  • Renamed IS_PIWEB to PI_WEB_TERMINAL to follow the existing PI_WEB_* convention and make its terminal-specific purpose explicit.
  • Removed the root allowScripts entry because it was unrelated to this change and is not enforced by the project's current npm installation flow. It therefore did not approve the node-pty install script or change installation behavior.
  • Strengthened the regression tests to cover both command terminals and continued interactive shells independently of the parent environment.

If dependency installation policy is still worth pursuing, please open a separate PR so its enforcement mechanism, package-manager support, documentation, and validation can be reviewed independently.

Thanks again!

@ongspxm ongspxm deleted the feat_addtermflag branch July 15, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants