Remove new tag from listings (JOB-5)#4
Draft
jmansfield wants to merge 1 commit into
Draft
Conversation
- Remove onsale class from all vacation listing <li> elements in exercises 04-08 - Remove 'On Sale Now' filter button from exercise 07 HTML - Remove onsale filter click handler from exercise 07 application.js - Keep expiring class and its filter button/handler intact Resolves JOB-5 Co-authored-by: James Mansfield <james.mansfield@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
onsale(new) tag from all vacation listing items across the jQuery exercises, resolving JOB-5.Changes
onsaleclass from all<li class="vacation onsale">elements (5 files)onsalelistings to filterapplication.jsThe
expiringclass and its associated filter button/handler were left intact as they serve a different purpose.Linear Issue: JOB-5