Mobile tabs: archive icon and blacklist circle on mobile#3
Draft
jmansfield wants to merge 1 commit into
Draft
Conversation
On mobile (<=600px): - Archived tab shows an SVG archive box icon instead of text - Blacklist tab shows a filled black circle alongside the label - Tab switching handled via jQuery click handlers Co-authored-by: James Mansfield <james.mansfield@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves JOB-18: On mobile, the archived tab shows an icon and the blacklist tab has a black circle in it.
Changes
Added a new exercise folder
22 Mobile tabs/with a tab navigation component that has responsive behavior:Files
22 Mobile tabs/index.html— Tab markup with inline SVG archive icon and a<span>styled as a black circle for the blacklist tab22 Mobile tabs/application.css— Tab styles with@media (max-width: 600px)responsive rules to show/hide icons vs. labels22 Mobile tabs/application.js— jQuery click handler for tab switchingLinear Issue: JOB-18