ci: drop preview sticky comment + fix Node 20 deprecation warnings#263
Merged
Conversation
- Remove the 'Comment preview URL on PR' step. The per-PR preview URL is already surfaced via the GitHub deployment/Environments UI on the PR, so the extra auto-comment on every push was noise. Also drop the now-unused pull-requests: write permission from the CI job. - Kill the Node 20 deprecation warnings by bumping actions to Node 24 runtimes: cloudflare/wrangler-action@v3 -> @v4 (ci.yml, release.yml) and actions/github-script@v7 -> @v9 (ci.yml, cleanup-preview.yml, rotate-apple-secret.yml). wrangler-action v4's only major change is wranglerVersion input flexibility (no behavior change for our usage).
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to reduce PR noise and eliminate Node 20 runtime deprecation warnings by bumping action major versions (Wrangler and github-script).
Changes:
- Remove the CI “Comment preview URL on PR” step and drop the now-unneeded
pull-requests: writepermission. - Bump
cloudflare/wrangler-actionfromv3tov4(CI + release workflows). - Bump
actions/github-scriptfromv7tov9(CI + maintenance workflows) to run on Node 24.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Removes the sticky PR preview comment and updates Wrangler/github-script action versions while keeping preview deployment URL surfaced via deployments UI. |
| .github/workflows/cleanup-preview.yml | Updates actions/github-script to v9 for the PR-close deployment cleanup workflow. |
| .github/workflows/release.yml | Updates Wrangler action to v4 for deploys to avoid Node 20 deprecation warnings. |
| .github/workflows/rotate-apple-secret.yml | Updates actions/github-script to v9 for scheduled Apple secret rotation. |
Comments suppressed due to low confidence (1)
.github/workflows/cleanup-preview.yml:20
cleanup-preview.ymlis deactivating deployments forpreview (${branch}), but the CI workflow creates deployments with environment namepreview (#<PR number>)(see.github/workflows/ci.ymlcreateDeployment call). As a result, this cleanup job will not find and deactivate the preview deployments created by CI, leaving stale active deployments after PR close.
uses: actions/github-script@v9
with:
script: |
const branch = context.payload.pull_request.head.ref;
const envName = `preview (${branch})`;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #262. Two cleanups + address the Node 20 deprecation notices.
1. Remove the preview sticky-comment step
The
Comment preview URL on PRstep auto-posted (and re-posted on every push) a comment like this one. It's redundant: the per-PR preview URL is already surfaced on the PR via the GitHub deployment / Environments UI (theBranch preview deploymentstep setsenvironment_url). Removing the comment cuts the noise. Also drops the now-unusedpull-requests: writepermission from the CI job (least privilege).2. Fix Node 20 deprecation warnings
CI was emitting:
Source: actions still pinned to Node 20 runtimes. Bumped to Node 24:
cloudflare/wrangler-action@v3→@v4(ci.yml, release.yml). v4's only major change iswranglerVersioninput flexibility (version ranges/tags); no behavior change for our exact-command usage.actions/github-script@v7→@v9(ci.yml, cleanup-preview.yml, rotate-apple-secret.yml). v9 runs on node24.All other actions (
checkout@v6,setup-node@v6,cache@v5) were already on Node 24.Verification
@v3wrangler-action /@v7github-script references remain.versions upload --preview-alias pr-<N>.Note: separately, the Copilot review comments on #259 are being handled on that PR.