Make library work with OpenBSD - #6
Open
codesoap wants to merge 1 commit into
Open
Conversation
The dynamic use of the library led to a segmentation violation on OpenBSD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenBSD I got the following error message:
Using the static variant of the library (
MediaInfoDLL/MediaInfoDLL_Static.hinstead ofMediaInfoDLL/MediaInfoDLL.h) seems to solve the issue. Instead of copying the header file in the Repository, I am now including the installed header file. Unfortunately I'm not familiar enough with C to understand why this works and the dynamic variant didn't.I have also added the additional paths needed to find the library on OpenBSD.
I have tested successfully on Linux and OpenBSD, but don't have access to a Darwin machine.