refactor(crankers): improve error diagnostics and build metadata#274
Open
stevennellson0619-arch wants to merge 1 commit into
Open
Conversation
- Replace bare unwrap() with descriptive expect() in metrics module - Add build script to embed git hash and build timestamp for runtime version identification - Verify protobuf compiler availability at build time Improves debuggability of cranker panics in production by providing context about which computation failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves debuggability of cranker panics and adds build metadata embedding.
Changes
crankers/src/metrics.rs: Replace bareunwrap()with descriptiveexpect()messagescrankers/build.rs: Embed git hash, build timestamp, and verify protoc availabilityMotivation
Bare
unwrap()in metrics computation produces generic panics that are hard to diagnose in production. Build metadata embedding enables runtime version identification.Testing