Steward Writer Service: Skip null transactions in listen loop#63
Open
aoikurokawa wants to merge 4 commits into
Open
Steward Writer Service: Skip null transactions in listen loop#63aoikurokawa wants to merge 4 commits into
aoikurokawa wants to merge 4 commits into
Conversation
aoikurokawa
commented
Jun 12, 2026
| until: Some(latest_signature), | ||
| limit: Some(NUM_TRANSACTIONS), | ||
| commitment: Some(CommitmentConfig::confirmed()), | ||
| commitment: Some(CommitmentConfig::finalized()), |
Collaborator
Author
There was a problem hiding this comment.
i think better to use same commitment level here
There was a problem hiding this comment.
Pull request overview
This PR hardens the steward writer pipeline against Solana RPC getTransaction responses that deserialize as null, and aligns signature polling to use finalized commitment when listening for new program activity.
Changes:
- Switch signature polling in the listen loop from
confirmedtofinalizedcommitment. - Update
retry_get_transactionsto skip transactions that fail due to anullgetTransactionresponse and log a warning instead of failing the whole batch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
steward-writer-service/src/main.rs |
Uses finalized commitment for get_signatures_for_address_with_config in the listen loop. |
core/src/rpc_utils.rs |
Skips getTransaction serde-null failures and adds a helper to detect the null-response error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aoikurokawa
changed the title
aoikurokawa
marked this pull request as ready for review
June 12, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.