Skip to content

Kobe Writer Service: Add parsing failure recovery#38

Open
aoikurokawa wants to merge 3 commits into
masterfrom
ak/rpc
Open

Kobe Writer Service: Add parsing failure recovery#38
aoikurokawa wants to merge 3 commits into
masterfrom
ak/rpc

Conversation

@aoikurokawa

@aoikurokawa aoikurokawa commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator

Problem

  • One of the gcp had corrupted file, kobe writer service failed to parsing and exit writing MEV info process

Solution

  • Add recovery for it, if the service failed to fetch file, parse file, try to next one

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds failure recovery logic to the Kobe Writer Service to handle corrupted or unavailable files on GCP servers. Instead of failing completely when encountering a bad file, the service now attempts to fetch and parse files from multiple GCP servers sequentially until one succeeds.

  • Refactored get_file_uris to accept a single server name instead of an array, simplifying the function's responsibility
  • Implemented a retry loop in write_mev_claims_info that attempts each GCP server in sequence with proper error handling and logging
  • Added comprehensive documentation explaining the fallback mechanism

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
writer-service/src/google_storage.rs Modified get_file_uris to accept a single server name parameter and improved error messages to include context
writer-service/src/db.rs Added retry loop to iterate through GCP servers, with error handling for each fetch/parse step and new documentation explaining the recovery mechanism

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread writer-service/src/db.rs Outdated
Comment thread writer-service/src/db.rs
Comment thread writer-service/src/db.rs Outdated
Comment thread writer-service/src/db.rs Outdated
@aoikurokawa
aoikurokawa marked this pull request as ready for review December 11, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants