Kobe Writer Service: Add parsing failure recovery#38
Open
aoikurokawa wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds failure recovery logic to the Kobe Writer Service to handle corrupted or unavailable files on GCP servers. Instead of failing completely when encountering a bad file, the service now attempts to fetch and parse files from multiple GCP servers sequentially until one succeeds.
- Refactored
get_file_uristo accept a single server name instead of an array, simplifying the function's responsibility - Implemented a retry loop in
write_mev_claims_infothat attempts each GCP server in sequence with proper error handling and logging - Added comprehensive documentation explaining the fallback mechanism
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| writer-service/src/google_storage.rs | Modified get_file_uris to accept a single server name parameter and improved error messages to include context |
| writer-service/src/db.rs | Added retry loop to iterate through GCP servers, with error handling for each fetch/parse step and new documentation explaining the recovery mechanism |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aoikurokawa
marked this pull request as ready for review
December 11, 2025 02:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution