Skip to content

Fix bundled dependency build issues #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinyuntang merged 2 commits into from
Aug 10, 2026
Merged

Fix bundled dependency build issues #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd1a0a7
Fix bundled dependency build
mrychlik Aug 8, 2026
8d67b21
Merge pull request #197 from mrychlik/codex/fix-bundled-dependency-build
jinyun1tang Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions 3rd-partylibs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ if (EXISTS ${BLOSC_LIBRARY})
message(STATUS "BLOSC_LIBRARY ${BLOSC_LIBRARY}")
endif()

if (NOT EXISTS ${CMAKE_CURRENT_BINARY_DIR}/hdf5)
if (NOT EXISTS ${HDF5_LIBRARY} OR NOT EXISTS ${HDF5_HL_LIBRARY})
message("Preparing hdf5...")
execute_process(COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_SOURCE_DIR}/hdf5 ${CMAKE_CURRENT_BINARY_DIR}/hdf5
RESULT_VARIABLE stat)
Expand Down Expand Up @@ -370,10 +370,13 @@ if (NOT EXISTS ${NETCDF_LIBRARY})
message("NETCDF_CPPFLAGS: ${NETCDF_CPPFLAGS}")
message("NETCDF_LIBFLAGS: ${NETCDF_LIBFLAGS}")

set(NETCDF_C_LIBS "-lhdf5_hl -lhdf5 -lz -ldl -lm")

#Original version
execute_process(COMMAND env CC=${CMAKE_C_COMPILER} env FC=${CMAKE_Fortran_COMPILER}
env CXX=${CMAKE_CXX_COMPILER} env CXXFLAGS=${CMAKE_CXX_FLAGS} env CPPFLAGS=-I${PROJECT_BINARY_DIR}/include
env CXX=${CMAKE_CXX_COMPILER} env CXXFLAGS=${CMAKE_CXX_FLAGS} env "CPPFLAGS=-D_GNU_SOURCE -I${PROJECT_BINARY_DIR}/include"
env CFLAGS=${CMAKE_C_FLAGS} env LDFLAGS=-L${PROJECT_BINARY_DIR}/lib
env LIBS=${NETCDF_C_LIBS}
./configure ${NETCDF_C_CONFIG_OPTS}
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/netcdf-c
OUTPUT_VARIABLE netcdf_c_config_log ERROR_VARIABLE netcdf_c_config_err
Expand Down
Loading