fix(coding-agent): resolve Termux env shebang hops - #19
Merged
Conversation
seoseo-ai
approved these changes
Aug 20, 2026
seoseo-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed exact head c0b0e513d2686c5ea7357984a83074b99c92daa6.
- The launcher resolves only
envshebangs and passes arguments as arrays without shell evaluation. env -Sfixed arguments are allowlisted; shell syntax is rejected and covered by a non-execution regression test.- The source launcher resolves
nodethroughPATHand invokes the pinned tsx module directly, removing the second/usr/bin/envhop. - CI
build-check-testandcheck-contributorare green at this head.
Approved with no blocking findings.
This review was prepared with Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env-based CLI shebangs throughPATHin the ccc-node launcher/usr/bin/env, safeenv -Sarguments, shell-syntax rejection, and the tsx hopWhy
Android/Termux does not provide
/usr/bin/env. When ccc-node intentionally strips the libtermux-execLD_PRELOADhook for an isolated subprocess, both Piri's CLI shebang and the source launcher's.bin/tsxshebang can fail before Node starts. This completes the Piri-side work tracked by jinwon-int/ccc-node#1184.Validation
node --test scripts/piri-ccc.test.mjs(8/8)bash -n scripts/piri-ccc.sh pi-test.shgit diff --checknpm run checkPer repository instructions, the full
npm testsuite was left to CI.This pull request was prepared with Codex.