Skip to content

fix(coding-agent): resolve Termux env shebang hops - #19

Merged
seoseo-ai merged 1 commit into
mainfrom
fix/termux-env-shebang-1184
Aug 20, 2026
Merged

fix(coding-agent): resolve Termux env shebang hops#19
seoseo-ai merged 1 commit into
mainfrom
fix/termux-env-shebang-1184

Conversation

@jinon86

@jinon86 jinon86 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve env-based CLI shebangs through PATH in the ccc-node launcher
  • invoke the pinned tsx module through the resolved Node binary in the source launcher
  • cover unavailable /usr/bin/env, safe env -S arguments, shell-syntax rejection, and the tsx hop

Why

Android/Termux does not provide /usr/bin/env. When ccc-node intentionally strips the libtermux-exec LD_PRELOAD hook for an isolated subprocess, both Piri's CLI shebang and the source launcher's .bin/tsx shebang can fail before Node starts. This completes the Piri-side work tracked by jinwon-int/ccc-node#1184.

Validation

  • node --test scripts/piri-ccc.test.mjs (8/8)
  • bash -n scripts/piri-ccc.sh pi-test.sh
  • git diff --check
  • npm run check

Per repository instructions, the full npm test suite was left to CI.

This pull request was prepared with Codex.

@jinon86
jinon86 requested a review from seoseo-ai August 20, 2026 03:51

@seoseo-ai seoseo-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head c0b0e513d2686c5ea7357984a83074b99c92daa6.

  • The launcher resolves only env shebangs and passes arguments as arrays without shell evaluation.
  • env -S fixed arguments are allowlisted; shell syntax is rejected and covered by a non-execution regression test.
  • The source launcher resolves node through PATH and invokes the pinned tsx module directly, removing the second /usr/bin/env hop.
  • CI build-check-test and check-contributor are green at this head.

Approved with no blocking findings.

This review was prepared with Codex.

@seoseo-ai
seoseo-ai merged commit 84859e4 into main Aug 20, 2026
2 checks passed
@seoseo-ai
seoseo-ai deleted the fix/termux-env-shebang-1184 branch August 20, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants