test: report Rozenite E2E case values - #205
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52db38c591
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| printCase(testCase); | ||
| cases.push(testCase); | ||
| } | ||
| writeGitHubSummary(cases); |
There was a problem hiding this comment.
Write the summary even when a case fails
When any host, panel, bundle, or Electron behavior assertion fails, control jumps directly to finally, so this call is never reached and the GitHub Actions job summary contains no case table precisely when the expected/actual diagnostics are most useful. The failure path should retain the failed case and emit the accumulated summary before propagating the error.
Useful? React with 👍 / 👎.
Summary
Validation
yarn test:e2e:rozenite— 10/10 cases passedbiome check scripts/test-rozenite-e2e.mjs scripts/rozenite-e2e-electron.cjsnode --check scripts/test-rozenite-e2e.mjsnode --check scripts/rozenite-e2e-electron.cjsgit diff --checkThe manual
/e2eworkflow was not triggered from this PR to avoid unnecessarily occupying both self-hosted mobile runners.