Skip to content

test: report Rozenite E2E case values - #205

Merged
jingjing2222 merged 1 commit into
mainfrom
test/rozenite-e2e-reporting
Aug 31, 2026
Merged

test: report Rozenite E2E case values#205
jingjing2222 merged 1 commit into
mainfrom
test/rozenite-e2e-reporting

Conversation

@jingjing2222

Copy link
Copy Markdown
Owner

Summary

  • print every Rozenite E2E case with its input, expected value, actual value, and pass/fail status
  • split the behavior coverage into explicit host, panel, bundle, position, distance-filter, max-updates, and cleanup cases
  • include the same 10-case result table in the GitHub Actions Job Summary
  • preserve failed browser-case expected/actual values in Electron output

Validation

  • yarn test:e2e:rozenite — 10/10 cases passed
  • biome check scripts/test-rozenite-e2e.mjs scripts/rozenite-e2e-electron.cjs
  • node --check scripts/test-rozenite-e2e.mjs
  • node --check scripts/rozenite-e2e-electron.cjs
  • git diff --check

The manual /e2e workflow was not triggered from this PR to avoid unnecessarily occupying both self-hosted mobile runners.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 52db38c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T01:03:22.053291Z 52db38c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52db38c591

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

printCase(testCase);
cases.push(testCase);
}
writeGitHubSummary(cases);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Write the summary even when a case fails

When any host, panel, bundle, or Electron behavior assertion fails, control jumps directly to finally, so this call is never reached and the GitHub Actions job summary contains no case table precisely when the expected/actual diagnostics are most useful. The failure path should retain the failed case and emit the accumulated summary before propagating the error.

Useful? React with 👍 / 👎.

@jingjing2222
jingjing2222 merged commit 7e5d50e into main Aug 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant