test: strengthen RC E2E quality gates - #180
Conversation
|
|
/e2e |
|
@jingjing2222 iOS E2E: cancelled
|
|
@jingjing2222 Android E2E: cancelled
|
b052d5a to
3da11a5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b052d5ac08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "missingNotification", | ||
| createScenarioResult("passed", shortError(error)) | ||
| createScenarioResult( | ||
| message.includes(MISSING_NOTIFICATION_ERROR) ? "passed" : "failed", |
There was a problem hiding this comment.
Use a bridge-valid object to test native validation
On Android, { android: {} as any } never reaches validateAndroidBackgroundOptions: Nitro's generated converter requires AndroidBackgroundLocationOptions.foregroundService and rejects the malformed object at the JS/native boundary with a generic conversion error. Consequently, the message cannot contain MISSING_NOTIFICATION_ERROR, this result is always marked failed, and background-e2e.yaml will fail every full Android E2E run. Omit android entirely or otherwise pass a bridge-valid value that reaches the intended Kotlin validation.
Useful? React with 👍 / 👎.
3da11a5 to
b16684e
Compare
Summary
agent-device[Bug] background location warnings on Android #132 driver with the existing Maestro flowas anyLocal verification
actionlint .github/workflows/e2e.ymlyarn format:checkyarn lintyarn typecheckyarn deadcodeyarn pack:checkyarn source-lines:checkyarn test:unit(186 tests)yarn test:e2e:webbash examples/v0.81.1/scripts/test-maestro-retry-flows.shDevice verification