Skip to content

test: strengthen RC E2E quality gates - #180

Merged
jingjing2222 merged 1 commit into
mainfrom
test/rc-e2e-quality-gates
Aug 25, 2026
Merged

test: strengthen RC E2E quality gates#180
jingjing2222 merged 1 commit into
mainfrom
test/rc-e2e-quality-gates

Conversation

@jingjing2222

@jingjing2222 jingjing2222 commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove four platform-mismatch flows that only reported a skipped scenario as passed
  • add the existing location-readiness happy/denied contract to both platform suites
  • require background permission, exact invalid-config, and native configuration round-trip evidence
  • run the isolated Android GPS-offline and no-Headless-JS regression suites in the repository E2E workflow
  • replace the unpinned agent-device [Bug] background location warnings on Android #132 driver with the existing Maestro flow
  • wait for app bootstrap before iOS deep links so navigation listeners cannot lose the route
  • exercise the natural cross-platform missing-Android-options path instead of bypassing Nitro types with as any

Local verification

  • actionlint .github/workflows/e2e.yml
  • yarn format:check
  • yarn lint
  • yarn typecheck
  • yarn deadcode
  • yarn pack:check
  • yarn source-lines:check
  • yarn test:unit (186 tests)
  • yarn test:e2e:web
  • bash examples/v0.81.1/scripts/test-maestro-retry-flows.sh
  • Android release APK: invalid-config native contract passed repeatedly

Device verification

@changeset-bot

changeset-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b16684e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jingjing2222

Copy link
Copy Markdown
Owner Author

/e2e

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@jingjing2222 iOS E2E: cancelled

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@jingjing2222 Android E2E: cancelled

@jingjing2222
jingjing2222 force-pushed the test/rc-e2e-quality-gates branch from b052d5a to 3da11a5 Compare August 25, 2026 09:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b052d5ac08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"missingNotification",
createScenarioResult("passed", shortError(error))
createScenarioResult(
message.includes(MISSING_NOTIFICATION_ERROR) ? "passed" : "failed",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use a bridge-valid object to test native validation

On Android, { android: {} as any } never reaches validateAndroidBackgroundOptions: Nitro's generated converter requires AndroidBackgroundLocationOptions.foregroundService and rejects the malformed object at the JS/native boundary with a generic conversion error. Consequently, the message cannot contain MISSING_NOTIFICATION_ERROR, this result is always marked failed, and background-e2e.yaml will fail every full Android E2E run. Omit android entirely or otherwise pass a bridge-valid value that reaches the intended Kotlin validation.

Useful? React with 👍 / 👎.

@jingjing2222
jingjing2222 force-pushed the test/rc-e2e-quality-gates branch from 3da11a5 to b16684e Compare August 25, 2026 10:18
@jingjing2222
jingjing2222 merged commit fc6104b into main Aug 25, 2026
13 of 15 checks passed
@jingjing2222
jingjing2222 deleted the test/rc-e2e-quality-gates branch August 25, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant