Bidirectional - close #12 - #17
Open
Jaykul wants to merge 7 commits into
Open
Conversation
Fix nick highlighting for IRC (and confusion for Slack) Remove extra slacker.js and update ReadMe
Change user messages on IRC to have <username> instead of username:
Jaykul
force-pushed
the
bidirectional
branch
from
February 20, 2015 18:08
a1b1f50 to
d89dd3b
Compare
Owner
|
Thanks so much for this @Jaykul - i've been completely slammed this week so I'll get into this and see if we can make it ready for a merge as soon as I can in the next day or so. |
|
What is the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a lot of changes (starting with changing to using the slack-client), and I'm sure the whole thing could be done better (I'm not a node guy), but it's working nicely for us, so I figured you'd like to have the code.
Importantly, I stripped the "op" feature because our bot isn't opped and it kept causing an error to be printed, and I also stripped the silent option (what is a silent bridge?) and added some features around formatting and message length.
We still have some issues ;-)