Fix OpenAI deprecated - #52
Open
WahadMasriDev wants to merge 14 commits into
Open
Conversation
added 12 commits
October 6, 2025 13:03
jie-jw-wu
reviewed
Oct 16, 2025
jie-jw-wu
reviewed
Oct 16, 2025
| intermediate_result = json.load(f) | ||
|
|
||
| with open(file_path + '/%s_dataset_%s_%s_%s/intermediate_result_among5.json' % (experiment, 'HumanEval', model, temperature), 'r') as fo: | ||
| with open(file_path + '/%s_dataset_%s_%s_%s/intermediate_result_among5.json' % (experiment, dataset, model, temperature), 'r') as fo: |
Owner
There was a problem hiding this comment.
are you sure this is correct? And why?
Collaborator
Author
There was a problem hiding this comment.
I had an error associated with this change so i let the path search for the dataset that is specified instead of it being hardcoded.
Owner
There was a problem hiding this comment.
I don't think this is correct. Refer to my comment in the other PR
jie-jw-wu
reviewed
Oct 16, 2025
jie-jw-wu
reviewed
Oct 16, 2025
jie-jw-wu
left a comment
jie-jw-wu
left a comment
Owner
There was a problem hiding this comment.
have you tested this PR and added the test screenshot to the PR description?
jie-jw-wu
reviewed
Oct 16, 2025
| # no clarifying questions being generated through the prompt | ||
| print("Running Designer") | ||
| test_cases = designer_main(model, "python", responses, openai.api_key, task_id) | ||
| test_cases = designer_main(model, "python", responses, os.environ.get('OPENAI_API_KEY') or os.environ.get('OPENAI_KEY'), task_id) |
Owner
There was a problem hiding this comment.
is it possible to wrap os.environ.get('OPENAI_API_KEY') or os.environ.get('OPENAI_KEY') into a util function?
Collaborator
Author
There was a problem hiding this comment.
Sure yes I will do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to make openai work some updates need to be done including changing the imports and changing how we deal with the openai library.