Fix settings action button contrast - #1
Merged
Conversation
Use an explicit prominent button style for settings actions so Save, Add, and Done always render with high-contrast text on a visible accent background across appearances. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR improves readability of primary action buttons in the Settings window by introducing a dedicated SwiftUI ButtonStyle that uses the system accent color fill paired with a high-contrast foreground, rather than relying on the default prominent button styling.
Changes:
- Introduces
SettingsProminentButtonStyle, parameterized byControlSize, to enforce consistent padding, corner radius, and pressed/disabled appearance. - Applies the shared style to the Settings primary actions (Save, Add, Done).
- Extends
SettingsPalettewith accent fill and text colors used by the new button style.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the settings window actions rendering with poor contrast, which made buttons like Save and Done hard to read in the current appearance. The change makes those primary actions explicitly readable instead of relying on the default prominent button styling.
What changed
SettingsProminentButtonStylethat uses the system accent fill with a high-contrast foreground color