Fix Windows release build failure on latest MSVC toolchain#28
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-app on Windows
Fix Windows release build failure on latest MSVC toolchain
Jul 1, 2026
jiacai2050
marked this pull request as ready for review
July 1, 2026 15:16
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Windows release build failure on windows-latest by adding a global Windows CMake compile definition intended to silence MSVC/STL deprecation diagnostics triggered by transitive Flutter Windows plugins.
Changes:
- Add
_SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGSviaadd_compile_definitions(...)in the top-level Windows CMake configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows release job started failing on
windows-latestduringflutter build windows. The breakage came from transitive Windows plugins (local_auth_windows,permission_handler_windows) hitting MSVC's new hard error for deprecated<experimental/coroutine>usage.Root cause
Compress-Archivefailure in the job was secondary; the build output was never produced.Change
windows/CMakeLists.txt:_SILENCE_EXPERIMENTAL_COROUTINE_DEPRECATION_WARNINGSWhy here