Repository navigation
Resume polish: share previews, CI, sourced college tips, Spanish /college, README - #25
Merged
Merged
Conversation
The quiz is the page people are most likely to share, but its layouts only set a title, so links showed the generic site card. The bonus quiz's description also named nuclear, petroleum and marine, which it doesn't cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The count was hardcoded, the same kind of drift that already had to be fixed twice elsewhere when the field list grew. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PageProps and LayoutProps live in .next/types, which a fresh CI checkout doesn't have, so tsc failed on its first run even though it passed locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…urces say Two cited blog posts, not research. The active-learning tip now cites the 2019 PNAS randomized study (Deslauriers et al.) and states its actual finding. The burnout tip now cites a 2022 systematic review of physical activity and burnout, says it shows an association in medical students, and drops the claims nothing supported. The internship tip's own source never said internships "fundamentally alter career trajectories", so it now reports what that paper found. Also notes that "R1" is a U.S. classification. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
/college was the only page of 64 still showing English text in Spanish mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jgomezrom
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/quizand/quiz/more-majorsonly set a title, so shared links showed the generic site card with no canonical URL. Both now have their own Open Graph/Twitter metadata and canonical. The bonus quiz's description also named nuclear, petroleum and marine, which it doesn't cover; it now names the seven fields it actually does.mainand every PR. Its first run caught a real gap:PageProps/LayoutPropsare generated into.next/types, which a fresh checkout doesn't have, so the workflow now runsnext typegenfirst./college— the only page of 64 still showing English in Spanish mode. The six tips are now translated (collegeTips.es.ts).fields.lengthinstead of hardcoded.public/.Test plan
tsc --noEmit,npm run lint,npm test(22/22),npm run build(73/73) pass locally.next) and confirmednext typegenfixes itog:url, canonical,og:image,summary_large_image; bonus quiz has its own canonical/collegewas the only one with English text/collegechecked in English and Spanish: all six tips, labels and source links render; theme/confidence/source identical across languages🤖 Generated with Claude Code