Handle more complex cluster topologies - #78
Open
jgaskins wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
Redis::Clusterassumes that a shard serves only a single range of hash slots. It also assumes that it's always a range, not a single slot. On a pristine cluster, this is generally true because it'll divide the hash slots among all the cluster primaries during initialization. But over time, as key slots are shuffled between shards to mitigate hot keys and rebalance memory consumption, you end up with a hash-slot distribution that isn't always quite so clean.This PR attempts to address this by allowing for multiple hash slots per node that are either a single hash slot, a range of slots, or a migration marker.
Fixes #76