Exposed more internal methods as external APIs#16
Open
petergeneric wants to merge 6 commits into
Open
Conversation
… Treat a single string like an array of size 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using your plugin (it's great, btw!), I've made a few adjustments for my own application which you may or may not be interested in.
Mainly I've been adding public methods (getVideo, getVideoIndex, setVideoIndex, addVideos).
I've updated how the src of a video is parsed. It allows the caller to provide a simple string rather than an array (this was useful for me because I'm generating the json for the video list in Java, and it let me keep that Java class simpler).
I've also added a mapping from .mov to video/mp4