Start Moving Tests to JS - #381
Draft
lishaduck wants to merge 4 commits into
Draft
Conversation
lishaduck
commented
Sep 26, 2025
|
|
||
| // TODO(@lishaduck): With ESM, this should use TLA. | ||
| require('../lib/main')(); | ||
| require('../lib/main').main(); |
Contributor
Author
There was a problem hiding this comment.
Was just thinking, we should ensure this doesn't break elmls.
As far as I can tell, it's just shelling out, correct?
https://github.com/elm-tooling/elm-language-server/blob/d0c9186ec7561abdf7d970be51767304b91d7f5b/src/common/providers/diagnostics/elmReviewDiagnostics.ts#L145-L150
lishaduck
force-pushed
the
big-refactor-pt-4
branch
5 times, most recently
from
September 28, 2025 02:45
7ac5b1d to
ed634cc
Compare
Contributor
Author
|
#151 is really confusing me... node-exit shouldn't be needed since node v0.12, which has been EOL for forever. I assume that means that there are other bugs in |
lishaduck
force-pushed
the
big-refactor-pt-4
branch
from
December 18, 2025 19:07
ed634cc to
e1e99dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on refactoring cwd (#382)Depends on #377.