Skip to content

CSS Sprint E-4: DevX polish - stylelint guard, 282 dead stubs gone, paved-path enforcement, discoverability#384

Merged
pftg merged 1 commit into
masterfrom
css-migration/e4-devx-polish
Jul 19, 2026
Merged

CSS Sprint E-4: DevX polish - stylelint guard, 282 dead stubs gone, paved-path enforcement, discoverability#384
pftg merged 1 commit into
masterfrom
css-migration/e4-devx-polish

Conversation

@pftg

@pftg pftg commented Jul 19, 2026

Copy link
Copy Markdown
Member

What this is

The answer to "can you improve more?" — a fresh-eyes audit found three real gaps, all closed here.

Shipped

  • stylelint institutionalized (bun run lint:css, minimal ruleset over the hand-maintained layer; legacy five + vendors ignored). The duplicate-declaration bug class CodeRabbit caught by hand now has an automated guard. no-duplicate-selectors deliberately demoted to warning: merging same-selector rules moves declarations across cascade positions — the exact C5/D1 trap — so humans decide those, never --fix.
  • 282 dead stubs removed: 264 empty-block rules + 4 empty media shells deleted, 14 duplicate declarations auto-fixed — every change byte-gated (all bundle fingerprints identical).
  • Paved path enforced, not just documented: test/unit/paved_path_guard_test.rb fails when a pages/*.css lands without its bin/qtest mapping or ownership-map entry (unit suite 267 runs green).
  • Discoverability: CLAUDE.md workflow pointer + lint step in new-page.md — a newcomer can now find the paved path from the entry-point docs.

Deliberately not done

  • homepage.css (7.6K lines) splitting — churn without measurable gain; semantic names + ownership map cover navigation.
  • Bulk duplicate-selector merging — 377 warnings left for humans, per the cascade-position trap.

Verification

Full macOS system suite 65/119 zero failures, zero baseline changes; Linux dtest-all EXIT=0; unit suite 267 green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V

…ed-path guard test, discoverability

- stylelint (minimal ruleset) wired as 'bun run lint:css' over the
  hand-maintained layer (pages/ + components/); legacy five + vendors
  ignored. 264 empty-block rules + 4 empty media shells deleted and 14
  duplicate declarations auto-fixed - ALL byte-gated (every bundle
  fingerprint identical). no-duplicate-selectors demoted to warning:
  merging same-selector rules moves declarations across cascade
  positions (the C5/D1 trap) - humans decide those, not --fix.
- test/unit/paved_path_guard_test.rb: every pages/*.css must have a
  bin/qtest mapping and an ownership-map entry - the new-page checklist
  is enforced, not just documented (unit suite 267 runs green).
- CLAUDE.md workflow pointer + lint step in new-page.md: the paved path
  is discoverable from the entry-point docs.
- .stylelintrc.json force-added (a broad gitignore pattern caught it).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@pftg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6a941660-e7dd-4d5b-a211-a627abe57080

📥 Commits

Reviewing files that changed from the base of the PR and between 4d0b65e and 93496a7.

⛔ Files ignored due to path filters (1)
  • bun.lockb is excluded by !**/bun.lockb
📒 Files selected for processing (18)
  • .stylelintrc.json
  • CLAUDE.md
  • docs/workflows/new-page.md
  • package.json
  • test/unit/paved_path_guard_test.rb
  • themes/beaver/assets/css/components/c-cta-blocks.css
  • themes/beaver/assets/css/components/c-social-share.css
  • themes/beaver/assets/css/components/info-card.css
  • themes/beaver/assets/css/components/testimonials.css
  • themes/beaver/assets/css/pages/about-us.css
  • themes/beaver/assets/css/pages/careers.css
  • themes/beaver/assets/css/pages/clients.css
  • themes/beaver/assets/css/pages/homepage.css
  • themes/beaver/assets/css/pages/services.css
  • themes/beaver/assets/css/pages/single-career.css
  • themes/beaver/assets/css/pages/single-service.css
  • themes/beaver/assets/css/pages/single-use-cases.css
  • themes/beaver/assets/css/pages/use-cases.css
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch css-migration/e4-devx-polish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pftg
pftg merged commit 6945b0d into master Jul 19, 2026
3 checks passed
@pftg
pftg deleted the css-migration/e4-devx-polish branch July 19, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant