Skip to content

CSS Sprint E-3 (final): CTA copies frozen with measured verdict; partial is canon; DevX exit assessment#383

Merged
pftg merged 1 commit into
masterfrom
css-migration/e3-one-cta-source
Jul 19, 2026
Merged

CSS Sprint E-3 (final): CTA copies frozen with measured verdict; partial is canon; DevX exit assessment#383
pftg merged 1 commit into
masterfrom
css-migration/e3-one-cta-source

Conversation

@pftg

@pftg pftg commented Jul 19, 2026

Copy link
Copy Markdown
Member

What this is

The final sprint of the paved-path loop, closed with a measured verdict rather than a forced abstraction.

Shipped

  • partials/page/cta.html duplicate data-node attribute fixed (browsers dropped the second attr, so rendered DOM is identical; the one test selector using the dropped id targets services/single's own copy — verified intact).
  • E-3's collapse item closed with evidence: the 5 inline CTA copies have structurally diverged from the partial (page-specific wrappers, fl-node-content drift, extra button-row modules on 3 pages). Collapsing them requires a param-soup partial that would worsen DevX. Verdict: copies are frozen legacy; the partial (used by about + the starter) is canon for all new pages per new-page.md.
  • DevX exit assessment recorded in the tracker: a new page = copy the starter, follow the checklist, reuse 5 components + three-tier cards, tokens resolve site-wide, one greedy-prefix line, one qtest entry, sub-minute verify loop. Remaining backlog = parked trigger-conditioned items only. Goal met.

Verification

Full macOS system suite 65/119 zero failures, zero baseline changes; Linux dtest-all EXIT=0.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V

…gacy; partial is canon

- partials/page/cta.html duplicate data-node attr removed (rendered DOM
  identical; the [data-node=x4hl...] test targets services/single's own
  copy, verified intact).
- Measured: the 5 inline copies diverged structurally (wrappers,
  fl-node-content drift, extra button-row modules on 3 pages) -
  collapsing needs a param-soup partial that would worsen DevX. Copies
  frozen; the partial + starter are the paved path for new pages.
- Tracker: DevX exit assessment recorded - goal met, remaining backlog
  is parked trigger-conditioned items only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@pftg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d5ff9ccb-8cfa-47c8-a439-c732403ef81c

📥 Commits

Reviewing files that changed from the base of the PR and between 7c485ad and edec74f.

📒 Files selected for processing (2)
  • docs/projects/2509-css-migration/TASK-TRACKER.md
  • themes/beaver/layouts/partials/page/cta.html
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch css-migration/e3-one-cta-source

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pftg
pftg merged commit 4d0b65e into master Jul 19, 2026
3 checks passed
@pftg
pftg deleted the css-migration/e3-one-cta-source branch July 19, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant