Skip to content

CSS Phase C sprint C1: shared testimonials component (7 consumers) + fast-gate test infrastructure#371

Merged
pftg merged 29 commits into
masterfrom
css-migration/c1-shared-components
Jul 19, 2026
Merged

CSS Phase C sprint C1: shared testimonials component (7 consumers) + fast-gate test infrastructure#371
pftg merged 29 commits into
masterfrom
css-migration/c1-shared-components

Conversation

@pftg

@pftg pftg commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What this is

Phase C sprint C1 — complete (spec: docs/projects/2509-css-migration/2026-07-12-css-maintainability-redesign.md): the shared-partial styles the R-sprint delta ports copied into sibling pages/*.css files now live ONCE each under components/, plus the fast-gate test infrastructure that makes micro-commit sprints affordable, plus cleanup/baseline work surfaced along the way.

The three extractions (C1.1-C1.3)

Component Rules Consumers Method
components/testimonials.css 133 7 pages 9 commits, one consumer each
components/cta-banner.css 10 6 pages (tracker guessed 8; clients/contact-us carry no cta rules) 3 commits via bin/css-split
components/header-cta.css 3 3 pages 1 commit

Wired as concat-slice members (never @import — postcss-import silently skips post-prelude imports; proven by plugin bisect; only critical/base.css is prelude). Page-specific variance (spacing variants, homepage swiper sizing, the rujwd9mzxche pair) stays per-page — full variance log in TASK-TRACKER.md §C1.

Gates on every extraction commit: converged build → only-target-bundle fingerprint change → per-bundle declaration-set equivalence (only the intended font-family literal→var(--font-system-ui) normalizations; the var resolves to the identical stack) → winner-map clean → scoped screenshot gate, zero baseline changes. Notable catch: a cross-media equal-specificity tie (ud8jroeig5h2 @860 vs @1115) flipped a mobile winner (+60px heading shift) — caught by the screenshot gate, rule excluded from the component; the preflight order-audit is now part of the method.

Evidence: per-bundle gzip ±35B (noise, by design — source dedup, not transfer optimization); fl-node refs in pages/*.css ~3,700 → 2,834. Final verification: full macOS system suite 65 runs / 119 screenshots / 0 failures, zero baseline changes; Linux full suite via bin/dtest-all.

Test infrastructure

  • bin/qtest (Ruby): scoped visual gate — builds once, runs only affected pages' tests, spends the remaining 90s wall budget on randomly-sampled extras (rotating whole-suite coverage). ~25-60s per micro-commit vs >5 min. Refuses to run on dirty screenshot fixtures.
  • rake test:critical: churn-based highest-risk subset (git-history analysis); rake test:system = full system suite (fixes the glob that silently excluded test/system/pages/); test:all unchanged (CI runs it).
  • bin/dtest-all (Ruby): whole suite in a detached Docker container against its own snapshot — local work continues while it runs.
  • bin/css-split (Ruby): the extraction tool — span-cut remainders (untouched regions byte-identical), brace/comment guards, validated against C1.1 ground truth.

Cleanups & baseline-drift fixes

  • 9 dead post-prelude @imports deleted (7 in component-bundle.css, 2 in pages files) — silently skipped in every build; output byte-identical.
  • 5 never-shipped c-pp-*.css files deleted (2,623 lines) — their only reference was the dead import chain; they never reached any compiled bundle. Output byte-identical.
  • free_consultation Linux drift root-caused: Gravity Forms applies gf_browser_* classes at load, producing two internally-stable render states (~10px form shift) — a force-refreshed baseline failed the very next run. Fixed by masking .gform_wrapper (repo precedent: blog-index .blog-post); verified stable across consecutive Docker runs. This was the pre-existing master-level dtest failure.
  • Flaky careers_page component tests deleted: never ran under the old test:critical glob, cannot hold a baseline (force-pass → immediate fail), baselines predated the Course nav + 2604 typography work; the careers page keeps stable desktop+mobile coverage via test_careers.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V

Paul Keen and others added 19 commits July 19, 2026 00:34
@claude
test(visual): bin/qtest scoped visual gate - affected-pages-only runs…
07e58db 
… in under a minute

The full per-commit stack (test:critical + bin/test + bin/dtest, each with
an in-harness Hugo rebuild) costs >5 min - unworkable for Phase C's ~20
micro-commits per sprint. qtest builds once (~11s, PRECOMPILED_ASSETS) and
runs only the changed files' pages via a Minitest -n filter derived from
the ownership map (~2.5s/test; measured 42s for a two-page run), plus the
orphan guard and color-system check. Site-wide or unmapped files escalate
to the full critical suite automatically.

Spec gate stack re-tiered (items 4-5): qtest per micro-commit; full
test:critical + bin/test + bin/dtest per component milestone and on the
branch head before the PR - the macOS full suite stays mandatory as the
only dedup-trap catcher.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
fix(qtest): default to --changed; validate page keys before paying fo…
6d43944 
…r the build

Bare bin/qtest built the site and only then errored 'no pages given'.
Now no-args means --changed (the common case), and unknown page keys
fail fast pre-build.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 components/testimonials.css extracted; about-us s…
782507e 
…wapped (1/7)

133-rule component = the 7-consumer intersection of the shared
testimonials partial's rules (node-id + pp-review scoped), canonical
order from about-us.css, font stacks normalized to var(--font-system-ui).
Wired as a concat-slice member before pages/about-us.css - NOT @import:
postcss-import silently skips post-prelude imports (only critical/
base.css sits in the concat prelude), verified by plugin bisect.

Excluded from the component by preflight order-audit:
- ud8jroeig5h2 @860 margin rule: ties with per-page @1115 keeps (equal
  specificity, both active <860px); extraction reordered the winner and
  shifted the heading module +60px on mobile - caught by qtest, root-
  caused via last-wins winner maps + DOM computed-style probe.
- 38ejkdz2v4cq spacing cluster + homepage swiper-svg sizing stay
  per-page (real value divergence; variance logged in tracker).

Gates: converged build x2; only the about-us bundle fingerprint changed;
decl-set diff = exactly 4 font-family literal->var swaps (stack
identical, def inlined site-wide via baseof); winner map clean modulo
cssnano de-grouping; DOM probe byte-identical to pre-change control;
qtest about-us 10 screenshots green, ZERO baseline changes;
gzip 14971 -> 14936 (noise).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
docs(css): C1.1 progress + method corrections - slice-member wiring, …
13e374c 
…variance log, order-audit traps

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 clients swapped to components/testimonials.css (2/7)
07b2652 
Same protocol as 782507e: 133 intersection rules removed from
pages/clients.css (removal set == component keys, verified), component
added as slice member before it. Gates: only clients bundle fingerprint
changed; decl-diff = the 4 font-family var-swaps; winner map clean
modulo cssnano de-grouping; qtest clients 9 screenshots green, zero
baseline changes; gzip 18651->18636.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 services swapped to components/testimonials.css (…
4bd7275 
…3/7)

Protocol of 782507e. Gates: only services bundle fingerprint changed;
decl-diff = the 4 font var-swaps; qtest services green (one transient
nav-hover error, clean on rerun), zero baseline changes;
gzip 19943->19973 (+30B noise).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 single-use-cases swapped to components/testimonia…
6f1f7c5 
…ls.css (4/7)

Protocol of 782507e. Gates: only single-use-cases bundle fingerprint
changed; decl-diff = the 4 font var-swaps; qtest green, zero baseline
changes; gzip 18845->18872 (+27B noise).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 single-service swapped to components/testimonials…
a86098a 
….css (5/7)

Protocol of 782507e. Gates: only single-service bundle fingerprint
changed; decl-set IDENTICAL (this file already used var() stacks);
qtest green, zero baseline changes; gzip 19066->19100 (+34B noise).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): use-cases @imports converted to slice members (C1.1 pr…
aa74a5b 
…ep, 6a/7)

pages/use-cases.css's two top-of-file @imports only worked because
critical/base.css is a pure-import prelude; inserting the testimonials
component before pages/use-cases.css would push them post-prelude where
postcss-import silently drops them. css-variables import dropped
outright (base.css's own prelude @import already inlines it,
skipDuplicates deduped the second copy); fl-builder-common-base becomes
a template slice member at the identical concat position.

Gate: compiled use-cases bundle BYTE-IDENTICAL, zero fingerprint changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
test(visual): qtest rewritten in Ruby - 90s wall budget + random rota…
7162f20 
…ting extras

Per review: Ruby not bash (repo is Ruby-tooled; the bash version had
already collected quoting bugs), YAGNI (component map only lists files
that exist). Scoped tests always run; leftover budget (default 90s,
--budget N) runs randomly-sampled non-scoped desktop+mobile tests so
repeated micro-commit runs rotate through the whole suite. Full
test:critical + bin/test + bin/dtest remain the pre-merge bar.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 use-cases swapped to components/testimonials.css …
dd35c07 
…(6/7)

Protocol of 782507e, on top of the 6a slice-member prep. use-cases
carries NO 38ejkdz2v4cq wrapper cluster (variance log) - its only keeps
are the two ud8jroeig5h2 margin rules. Gates: only use-cases bundle
fingerprint changed; decl-set IDENTICAL (already var() stacks); qtest
green, zero baseline changes; gzip 16965->16977 (+12B noise).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): delete dead homepage swiper-svg 24px rule (C1.1 prep, 7a)
90e00d2 
.fl-node-08kl1yzxeout .pp-swiper-button svg {24px} (line 1277) was
shadowed by the identical-specificity 48px rule at 10317 (last wins) -
production output already discarded it (all bundle fingerprints
byte-identical after deletion, winner map identical). Removing it
BEFORE the component swap prevents a keep-fires-last flip to 24px.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
fix(qtest): sample random extras per test file - cross-file name batc…
50d67db 
…hes ran 0 tests and failed the gate

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.1 homepage swapped to components/testimonials.css (…
80981da 
…7/7)

Final consumer. The splitter removed BOTH in-file copies of the block
(263 removals, unique set == component keys; the second copy is 5 rules
short - verified subset). Slice member inserted before
pages/homepage.css in homepage-css-resources.html. Gates: only the
homepage bundle fingerprint changed; decl-set IDENTICAL (already var()
stacks; production had already deduped the second copy); winner map
clean; qtest homepage + random extras green, zero baseline changes;
gzip 26644->26632.

C1.1 extraction complete: testimonials styles live ONCE in
components/testimonials.css for all 7 consumers (~130 rules x 6 copies
deduplicated at source; shipped bytes unchanged by design).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
upgrades postcss
1dba353
@claude
test: churn-based test:critical subset + qtest fixtures guard + bin/d…
9bac6a9 
…test-all background runner

- test:critical now runs only the highest-risk pages (git-churn analysis
  2026-07-19: blog + homepage + course + site-wide dominate 6-month
  history; plus the services/contact/free-consultation funnel and the
  mermaid/codeblock special-content locks). Full system suite moves to
  test:system; test:all unchanged (CI runs test:all already).
- qtest refuses to start with dirty screenshot fixtures - a run REWRITES
  baselines, so starting dirty makes results unjudgeable (bit twice this
  session).
- bin/dtest-all: whole suite (rake test:all) in a detached Docker
  container against its own _dest/public-dtest-all snapshot, logging to
  tmp/dtest-all.log (EXIT=n last line) - local work continues while it
  runs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): delete 9 dead post-prelude @imports (audit of the sile…
5a11cc1 
…nt-skip warnings)

The postcss-import bisect during C1.1 exposed warnings for @imports that
postcss-import silently skips (post-prelude position). Audit result:
- component-bundle.css lines 2886-2907: seven c-pp/c-hero/c-cta imports,
  skipped in every production build of blog-list + free-consultation;
  content ships site-wide anyway via the components.css INLINE bundle in
  baseof.html (verified: c-hero selectors present in compiled bundles) -
  dead lines, deleted with a tombstone comment.
- pages/single-service.css + pages/homepage.css: css-variables imports,
  skipped; the def arrives via critical/base.css's prelude import chain
  and the baseof inline nav bundle - dead lines, deleted.

Gate: converged build x2, ALL bundle fingerprints byte-identical.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
test(css): bin/css-split - Ruby extraction tool for C1 component sprints
c2e2691 
Replaces the C1.1 scratchpad awk pipeline (which caused the wrong-line
dedupe and truncated-header defects). Modes: extract (pattern -> keys),
keys / component / remainder (keyset-driven split preserving document
order and @media grouping). Built-in guards: brace balance + comment
closure on every input. Validated against the C1.1 ground truth:
identical key multiset on the original about-us.css.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
docs(css): tracker - C1.1 shipped, pre-existing test:all failures logged
b4d3202 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@coderabbitai

coderabbitai Bot commented Jul 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@pftg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 21 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9cfb00c1-a91a-443b-90a5-7142ce9c9863

📥 Commits

Reviewing files that changed from the base of the PR and between b4d3202 and e696847.

⛔ Files ignored due to path filters (10)
  • test/fixtures/screenshots/linux/pages/careers/benefits-section.png is excluded by !**/*.png
  • test/fixtures/screenshots/linux/pages/careers/benefits-spacing.png is excluded by !**/*.png
  • test/fixtures/screenshots/linux/pages/careers/careers-page-full.png is excluded by !**/*.png
  • test/fixtures/screenshots/linux/pages/careers/feature-cards-section.png is excluded by !**/*.png
  • test/fixtures/screenshots/linux/pages/careers/newsletter-section.png is excluded by !**/*.png
  • test/fixtures/screenshots/macos/pages/careers/benefits-section.png is excluded by !**/*.png
  • test/fixtures/screenshots/macos/pages/careers/benefits-spacing.png is excluded by !**/*.png
  • test/fixtures/screenshots/macos/pages/careers/careers-page-full.png is excluded by !**/*.png
  • test/fixtures/screenshots/macos/pages/careers/feature-cards-section.png is excluded by !**/*.png
  • test/fixtures/screenshots/macos/pages/careers/newsletter-section.png is excluded by !**/*.png
📒 Files selected for processing (26)
  • bin/css-split
  • docs/projects/2509-css-migration/TASK-TRACKER.md
  • docs/projects/2509-css-migration/css-bundle-ownership-map.md
  • test/system/desktop_site_test.rb
  • test/system/pages/careers_page_test.rb
  • themes/beaver/assets/css/components/c-pp-advanced-menu.css
  • themes/beaver/assets/css/components/c-pp-buttons.css
  • themes/beaver/assets/css/components/c-pp-content-grid.css
  • themes/beaver/assets/css/components/c-pp-infobox.css
  • themes/beaver/assets/css/components/c-pp-widgets.css
  • themes/beaver/assets/css/components/cta-banner.css
  • themes/beaver/assets/css/components/header-cta.css
  • themes/beaver/assets/css/pages/about-us.css
  • themes/beaver/assets/css/pages/clients.css
  • themes/beaver/assets/css/pages/homepage.css
  • themes/beaver/assets/css/pages/services.css
  • themes/beaver/assets/css/pages/single-service.css
  • themes/beaver/assets/css/pages/single-use-cases.css
  • themes/beaver/assets/css/pages/use-cases.css
  • themes/beaver/layouts/page/about.html
  • themes/beaver/layouts/page/clients.html
  • themes/beaver/layouts/page/services.html
  • themes/beaver/layouts/page/use-cases.html
  • themes/beaver/layouts/partials/assets/homepage-css-resources.html
  • themes/beaver/layouts/services/single.html
  • themes/beaver/layouts/use-cases/single.html
📝 Walkthrough

Walkthrough

The change adds scoped visual-test and full-suite runners, introduces CSS splitting utilities, extracts shared testimonials styling, wires it into page bundles, and replaces duplicated page-specific review CSS with shared rating and infolist rules.

Changes

CSS testing and migration

Layer / File(s) Summary
Scoped test-gate tooling
bin/qtest, Rakefile, bin/dtest-all, .okf/build/test-gates.md, .okf/log.md, docs/projects/2509-css-migration/...		 Adds changed-file page mapping, scoped screenshot execution, critical-suite escalation, Docker full-suite execution, updated Rake tasks, and revised gate documentation.
CSS splitting and normalization
bin/css-split, package.json		 Adds CSS parsing, normalization, extraction, component/remainder generation, and updates the PostCSS development dependency.
Shared testimonials component
themes/beaver/assets/css/components/testimonials.css, themes/beaver/layouts/..., themes/beaver/assets/css/component-bundle.css		 Adds shared testimonial carousel/card styling, wires it into affected bundles, and removes dead component imports.
Page CSS migration
themes/beaver/assets/css/pages/*.css		 Replaces page-specific review styling with rating and infolist rules, removes duplicate builder styles, and adjusts responsive layouts across page bundles.

Estimated code review effort: 5 (Critical) | ~120 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Developer
  participant qtest
  participant Hugo
  participant ScreenshotTests
  participant CriticalSuite
  Developer->>qtest: run --changed
  qtest->>qtest: map changed files to page keys
  qtest->>Hugo: build scoped assets
  qtest->>ScreenshotTests: run filtered desktop/mobile tests
  qtest->>CriticalSuite: escalate for site-wide or unmapped changes
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two main changes: shared testimonials CSS extraction and new fast-gate test infrastructure.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch css-migration/c1-shared-components

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Paul Keen and others added 3 commits July 19, 2026 02:18
@claude
refactor(css): C1.2 components/cta-banner.css extracted; about-us swa…
e0460e1 
…pped (1/6)

10-rule intersection of the shared CTA partial (partials/page/cta.html)
across its 6 real consumers (tracker guessed 8; clients + contact-us
carry no cta node rules). Zero selector+property ties with any keep -
order-safe by construction. Variance kept per-page: the rujwd9mzxche
rich-text pair (5 pages; services has none) and about-us's fdsvgxpowi03
spacing cluster. Remainders generated by bin/css-split span-cut mode
(untouched regions byte-identical).

Gate: only about-us fingerprint changed; decl-set identical.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.2 homepage swapped to components/cta-banner.css (2/6)
c837cbe 
Gate: only homepage fingerprint changed; decl-set identical.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): C1.2 services, single-service, single-use-cases, use-c…
43c3b2c 
…ases swapped to cta-banner (3-6/6)

C1.2 complete: CTA banner styles live once for all 6 consumers.
Gate: exactly these 4 bundle fingerprints changed; per-bundle decl-set
identical (0 missing / 0 extra each).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
coderabbitai[bot]
coderabbitai Bot reviewed Jul 19, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bin/css-split`:
- Around line 31-34: Update normalize so rule-key canonicalization removes
comments and insignificant formatting without stripping semantic whitespace
between CSS tokens. Ensure selectors such as “.a .b” and “.a.b” produce distinct
keys, while applying the same token-preserving normalization to the media
portion.
- Around line 39-90: Update parse so both the initial brace validation and the
main scanner ignore braces and comment markers occurring inside quoted strings.
Track single- or double-quote state plus backslash escapes while scanning,
process comment delimiters only outside strings, and only update nesting depth
or split rules for syntax encountered outside comments and strings.
- Around line 105-106: Update the selector extraction and matching in the
css-split flow so leading section comments are removed before evaluating pat.
Ensure r.key is printed only when pat matches actual selector text, not comment
content, while preserving the existing rule extraction behavior.

In `@themes/beaver/assets/css/pages/about-us.css`:
- Around line 2949-2955: Remove the duplicated second font-style declaration
from the .pp-rating i rule in themes/beaver/assets/css/pages/about-us.css
(2949-2955), themes/beaver/assets/css/pages/clients.css (3487-3493),
themes/beaver/assets/css/pages/services.css (4490-4496),
themes/beaver/assets/css/pages/single-service.css (3586-3592),
themes/beaver/assets/css/pages/single-use-cases.css (3432-3438), and
themes/beaver/assets/css/pages/use-cases.css (2324-2330), leaving one
font-style: normal declaration in each rule.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5967bdb7-4a49-464f-8316-8816ce1390f5

📥 Commits

Reviewing files that changed from the base of the PR and between 5aaaece and b4d3202.

⛔ Files ignored due to path filters (1)
  • bun.lockb is excluded by !**/bun.lockb
📒 Files selected for processing (25)
  • .okf/build/test-gates.md
  • .okf/log.md
  • Rakefile
  • bin/css-split
  • bin/dtest-all
  • bin/qtest
  • docs/projects/2509-css-migration/2026-07-12-css-maintainability-redesign.md
  • docs/projects/2509-css-migration/TASK-TRACKER.md
  • package.json
  • themes/beaver/assets/css/component-bundle.css
  • themes/beaver/assets/css/components/testimonials.css
  • themes/beaver/assets/css/pages/about-us.css
  • themes/beaver/assets/css/pages/clients.css
  • themes/beaver/assets/css/pages/homepage.css
  • themes/beaver/assets/css/pages/services.css
  • themes/beaver/assets/css/pages/single-service.css
  • themes/beaver/assets/css/pages/single-use-cases.css
  • themes/beaver/assets/css/pages/use-cases.css
  • themes/beaver/layouts/page/about.html
  • themes/beaver/layouts/page/clients.html
  • themes/beaver/layouts/page/services.html
  • themes/beaver/layouts/page/use-cases.html
  • themes/beaver/layouts/partials/assets/homepage-css-resources.html
  • themes/beaver/layouts/services/single.html
  • themes/beaver/layouts/use-cases/single.html

Comment thread bin/css-split Outdated
Comment thread bin/css-split
Comment thread bin/css-split Outdated
Comment thread themes/beaver/assets/css/pages/about-us.css
Paul Keen and others added 6 commits July 19, 2026 02:20
@claude
refactor(css): C1.3 components/header-cta.css - bf72bba trio extracte…
b7637c8 
…d for its 3 consumers

Byte-identical across use-cases/clients/services (verified); zero
selector+property ties. Gate: exactly the 3 bundle fingerprints changed;
per-bundle decl-set identical.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
refactor(css): delete 5 never-shipped c-pp component files (2,623 lines)
f1081dc 
Orphaned by the dead-import cleanup (5a11cc1): their ONLY reference was
component-bundle.css's post-prelude @imports, which postcss-import
always skipped - so these files never reached any compiled bundle.
components.css (the inline site-wide bundle) does not import them.
Caught by the orphan guard in the qtest run. Gate: all bundle
fingerprints identical.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
test: delete flaky, redundant careers_page component tests + their ba…
45e2809 
…selines

test/system/pages/careers_page_test.rb never ran under test:critical
(single-star glob never descended into pages/) and cannot hold a
baseline: a FORCE_SCREENSHOT_UPDATE pass followed by an immediate rerun
fails 5/5 - the captures are unstable run-to-run (no stability waits;
baselines predate the Course nav link and the 2604 typography work).
The careers page keeps stable coverage via test_careers in the desktop
AND mobile suites. Surfaced by the new test:system/dtest-all coverage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
fix(css-split): span-cut remainder mode - untouched regions stay byte…
93c8e19 
…-identical

The first version re-wrapped every surviving @media rule into fresh
shells, reflowing whole files (remainders came out LONGER than inputs
and every consumer diff became a full-file rewrite). Remainders are now
produced by cutting removed-rule spans from the original text; a media
shell is only cut whole when ALL its inner rules are removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
test(visual): mask the Gravity Forms region on free_consultation - bi…
ebeee56 
…modal load-time state

The linux capture alternates between two internally-stable render states
(gf_browser_* classes decided at load; ~10px form shift) - a
FORCE-refreshed baseline failed the very next run, and
stability_time_limit cannot help a per-load fork. Masked .gform_wrapper
(precedent: blog/index .blog-post) and re-recorded BOTH platform
baselines; verified stable across consecutive docker runs. This was the
pre-existing master-level dtest failure documented in PR #371.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
docs(css): C1 complete - tracker C1.2-C1.5 evidence + ownership map c…
d7ebc83 
…omponents section

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@claude
fix: address CodeRabbit review - css-split hardening + duplicate decl…
e696847 
…aration cleanup

- css-split normalize keeps descendant-combinator spaces (.a .b vs .a.b
  no longer collide as keys; the 6 collisions this reveals in C1 scope
  were benign - every compiled decl-set gate showed 0 missing/0 extra).
- Scanner + brace-balance precheck are now string-literal aware
  (content: "}" parses instead of aborting).
- extract mode strips leading comments before pattern-matching selectors.
- Removed the doubled font-style:normal in the copied .pp-rating i block
  across 7 page files. CORRECTION vs the review thread: cssnano does NOT
  dedupe within-rule declarations - the 7 touched bundles' fingerprints
  DO change; gate = per-bundle declaration-set identical (0 missing /
  0 extra) + scoped screenshot run green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYRU9wGepomJo5hSuqtu7V
@pftg
pftg force-pushed the css-migration/c1-shared-components branch from f991038 to e696847 Compare July 19, 2026 00:50
@pftg
pftg merged commit 23f2a8e into master Jul 19, 2026
3 checks passed
@pftg
pftg deleted the css-migration/c1-shared-components branch July 19, 2026 00:56
This was referenced Jul 19, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pftg