chore: harden totp re-use and account enumeration#1758
Open
paustint wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens authentication flows against account enumeration and one-time-code replay by tightening TOTP acceptance, enforcing single-use OTP consumption, and making credential/password-reset responses more uniform in timing and messaging.
Changes:
- Tighten TOTP verification skew tolerance and add a DB-backed single-use guard for 2FA OTP codes.
- Mitigate login enumeration by equalizing the account-not-found vs wrong-password bcrypt cost and unifying invalid-credentials messaging.
- Reduce password-reset enumeration via timing by not awaiting the email-provider round trip.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| libs/auth/server/src/lib/auth.service.ts | Introduces a smaller TOTP grace period constant and uses it during TOTP verification. |
| libs/auth/server/src/lib/auth.db.service.ts | Adds dummy bcrypt work on account-not-found and unifies InvalidCredentials messaging. |
| apps/api/src/app/controllers/auth.controller.ts | Adds TOTP replay protection via DbCacheProvider and makes password-reset email sending fire-and-forget. |
| apps/api/src/app/controllers/tests/auth.controller.spec.ts | Extends api-config mock to include DbCacheProvider for controller tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2447730 to
5f76e55
Compare
5f76e55 to
395add3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.