Update to support newer Puppet versions (7 & 8)#14
Open
sec-ml wants to merge 16 commits into
Open
Conversation
- Remove `validate_string` function. Could use `validate_legacy()`, although this is deprecated too. Use `assert_type` instead. - `ensure_packages` is deprecated. Replace with `stdlib::ensure_packages`.
Update `systemd` service name. `strongswan` -> `strongswan-starter`. Ref: https://wiki.strongswan.org/projects/strongswan/wiki/580
- puppetlabs/firewall 8.0.1 doesn't support `action`. Uses `jump` instead? - `protocol` instead of `provider`
As per https://docs.strongswan.org/docs/5.9/interop/appleIkev2Profile.html: >Apple clients can only process PKCS#12 containers that are protected with 3DES and the legacy KDF. So when using openssl pkcs12 with OpenSSL 3.0 and newer, the -legacy option is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jethrocarr - there's a bunch of different things in here. Let me know if you have any questions about any of the decisions I've made.
Main fixes:
thias-sysctlbeing abandoned -include_legacy_facts=truerequired for now)strongswan=>strongswan-starterI've added some info to the readme, but probably worth removing compatibility for older OSes now - will leave that up to you.