canbus: handle socket bind failures - #6
Open
Opriego wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canbus_connectreturn its existing bind error code whenbindreturns-1Problem
canbus_connectchecks whetherbindreturns a value less than-1. POSIXsocket errors are reported as
-1, so the function ignores a normal bindfailure, continues configuring the socket, marks the client connected, and
returns success.
Fix
Change the bind result check from
< -1to< 0.Testing
The regression test wraps the socket calls so that
socketandioctlsucceedwhile
bindreturns-1. It also verifies that socket options are not appliedafter the bind failure.
Before the fix:
After the fix:
The existing
canbus_shutdownpointer/integer comparison warning is unrelatedand remains unchanged.