j2534: handle null PassThruOpen parameters - #4
Open
Opriego wants to merge 1 commit into
Open
Conversation
Opriego
force-pushed
the
fix/passthru-open-null-handling
branch
from
August 17, 2026 09:39
61ab265 to
e0ead75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PassThruOpenparameterspNameandpDeviceIDbefore either pointer is usedERR_NULL_PARAMETERinstead of crashingProblem
PassThruOpendereferencespDeviceIDin its log statement and callsstrlen(pName)while calculating MQTT topic lengths before checking whethereither pointer is
NULL. As a result, invalid required pointers can cause asegmentation fault instead of returning
ERR_NULL_PARAMETER.Fix
Set
j2534_current_api_calland perform the existing null-pointer guard beforethe log statement, topic-length calculations, or any other use of the input
pointers.
Testing
The regression test compiles the real
src/j2534.cwith function/data sections,links with garbage collection enabled, and stubs only dependencies reachable
from
PassThruOpen.Before the fix:
After the fix: