Skip to content

Added Celluloid::IO::SSLSocket#15

Open
ilyacherevkov wants to merge 2 commits into
jeremyd:masterfrom
ilyacherevkov:patch-1
Open

Added Celluloid::IO::SSLSocket#15
ilyacherevkov wants to merge 2 commits into
jeremyd:masterfrom
ilyacherevkov:patch-1

Conversation

@ilyacherevkov

Copy link
Copy Markdown

I'm newbie in this, but it solved my issue with SSL

I'm newbie in this, but it solved my issue with SSL
@slhck

slhck commented May 24, 2015

Copy link
Copy Markdown

Your indentation is wrong – make sure you indent using spaces, not tabs.

Also, wouldn't it make sense to conditionally set @socket to either Celluloid::IO::TCPSocket.new(uri.host, port) or the new SSL socket? Currently, it sets @socket first, and then, if it's SSL, sets it again.

@ilyacherevkov

Copy link
Copy Markdown
Author

You are right about indention. I've added new commit.
Regarding conditional set, SSLSocket should be actually Celluloid::IO::SSLSocket. And according to CelluloidIO source, it requires Celluloid::IO::TCPSocket object first as far as I understand.

But, probably, it's completely wrong.

@ilyacherevkov ilyacherevkov changed the title Added SSLSocket Added Celluloid::IO::SSLSocket May 24, 2015
@froy001

froy001 commented Jul 7, 2015

Copy link
Copy Markdown

This is a very much needed pull request. Please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants