Add uv install options, migrate setup.py to pyproject.toml - #68
Merged
Conversation
Support three installation paths so users can choose between conda and uv without dropping conda: 1. conda + pip 2. conda + uv 3. uv only (no conda) Move package metadata and dependencies from setup.py into pyproject.toml. setup.py declared no dependencies because conda (env.yml) supplied them, so pip/uv installed only the pyathena package. Declaring dependencies in pyproject.toml lets the uv-only path resolve them from PyPI, while the conda paths use --no-deps so pip does not reinstall packages conda already provided as binaries (healpy, netCDF4, and similar). env.yml is kept unchanged for the conda paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Document how to remove the package alone, the whole conda environment, and the uv-only .venv, matching the three installation options. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use *.egg-info so any distribution name is ignored, and ignore uv/venv environments created in the project directory. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for installing pyathena with uv alongside the existing conda + pip flow, without dropping conda. The README now documents three installation options:
pip install -e . --no-depsuv pip install -e . --no-deps, faster editable resolveuv venv+uv pip install -e ., all dependencies from PyPIChanges
setup.pytopyproject.toml; deletesetup.py.env.ymlintopyproject.toml[project.dependencies].Why
--no-depson the conda pathssetup.pydeclared no dependencies, sopip install -e .installed only the pyathena package and relied on conda (env.yml) for everything else. Declaring dependencies inpyproject.tomlis what lets the uv-only path resolve them from PyPI. To keep the conda paths behaving as before — and to avoid pip pulling PyPI wheels over conda-provided binaries such ashealpyandnetCDF4— the conda paths now pass--no-deps.env.ymlis unchanged; it remains the dependency source for the conda paths.Notes
🤖 Generated with Claude Code