Skip to content

chore: update dependencies and align linting - #532

Open
KristjanESPERANTO wants to merge 4 commits into
jens-maus:masterfrom
KristjanESPERANTO:update
Open

chore: update dependencies and align linting#532
KristjanESPERANTO wants to merge 4 commits into
jens-maus:masterfrom
KristjanESPERANTO:update

Conversation

@KristjanESPERANTO

@KristjanESPERANTO KristjanESPERANTO commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

This updates the project dependencies, including rrule-temporal, xo, lint-staged, and moment-timezone.

The new xo version introduced a few new rules, so I addressed the resulting findings. I also used the opportunity to remove lint rules and overrides that are outdated or no longer relevant.

Summary by CodeRabbit

  • Bug Fixes

    • Improved calendar parsing and normalization for recurring rules, time zones, durations, and date-only values.
    • Improved handling of time zone definitions and UNTIL values, including Microsoft and non-UTC formats.
    • Preserved correct expansion and ordering of recurring events, including edge cases around daylight-saving changes.
  • Tests

    • Strengthened coverage for recurring events, time zones, alarms, component indexing, and error handling.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9541accc-c6ef-4311-91c8-d60737f5dab6

📥 Commits

Reviewing files that changed from the base of the PR and between 50b4d7f and 3a8a96c.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (14)
  • examples/example.js
  • lib/expand-recurring-event.js
  • lib/ical-parser-utils.js
  • package.json
  • test/advanced.test.js
  • test/async-error-handling.test.js
  • test/basic.test.js
  • test/date-only-rrule-until.test.js
  • test/expand-recurring-event.test.js
  • test/extended-components.test.js
  • test/google-calendar-until-bug.test.js
  • test/non-utc-until.test.js
  • test/polyfill-check.test.js
  • test/tz-utils.test.js

📝 Walkthrough

Walkthrough

This PR refactors iCalendar parsing and timezone normalization, simplifies recurrence expansion and example control flow, updates tooling versions and lint rules, and strengthens related regression assertions.

Changes

iCalendar recurrence maintenance

Layer / File(s) Summary
Parser normalization and timezone lookup
lib/ical-parser-utils.js, package.json
Parsing guards, boolean names, RRULE UNTIL formatting, date-only detection, and VTIMEZONE lookup are refactored; dependency versions and lint rules are updated.
Recurrence expansion and example flow
lib/expand-recurring-event.js, examples/example.js
Non-recurring range checks and event filtering use early exits, and the recurrence function uses an inline default export.
Regression assertion updates
test/*.test.js
Assertions for RRULEs, timezones, recurrence expansion, callbacks, components, polyfills, and error propagation are made more explicit.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: dependency updates and linting alignment.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant