feat(home): make PR list items middle-clickable via BlockLink - #364
Merged
Conversation
Home-page PR rows were rendered as <button> elements, so users could not middle-click to open a PR in a new tab. Introduce a reusable BlockLink component: BlockLink.Root wraps the clickable card and re-dispatches click events onto the nested BlockLink.Link, while BlockLink.Link renders an actual <a> (so the browser handles middle/cmd/ctrl click natively) and stops propagation to avoid firing twice. BlockLink.Link supports an asChild prop backed by a small Slot utility that spreads its props onto its only child. The PR title on the home list is now a BlockLink.Link with the PR's canonical href, and plain left-clicks still route through the existing openPRReviewTab flow for SPA navigation. Resolves #362
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home-page PR rows were rendered as
<button>elements, so users could not middle-click to open a PR in a new tab. Introduce a reusableBlockLinkcomponent:BlockLink.Rootwraps the clickable card and re-dispatches click events onto the nested BlockLink.Link, while BlockLink.Link renders an actual<a>(so the browser handles middle/cmd/ctrl click natively) and stops propagation to avoid firing twice. BlockLink.Link supports an asChild prop backed by a small Slot utility that spreads its props onto its only child.The PR title on the home list is now a
BlockLink.Linkwith the PR's canonical href, and plain left-clicks still route through the existingopenPRReviewTabflow for SPA navigation.Resolves #362