Fix merged nodes - #49
Open
dorbarker wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that can occur when the taxonomy database is newer than the
kraken2database. Sometimes taxid nodes get merged. The merged nodes are removed fromnodes.dmpand noted inmerged.dmp.So if you've generated your
kraken2results with the latest pre-built databases, but have runmake_ktaxonomy.pywith a freshly downloaded taxonomy,make_kreport.pywill fail because it finds taxids that are not in the taxonomy.This PR will add the obsolete taxid as a child of the updated taxid. This allows
make_kreport.pyto still run if the situation described above arises.