Skip to content

Stop adding TimingAction in WorkflowRun$GraphL and let workflow-cps handle it instead #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dwnusbaum wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Stop adding TimingAction in WorkflowRun$GraphL and let workflow-cps handle it instead #548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2041e36
Check if GraphL still needs to add TimingAction
dwnusbaum Jul 1, 2025
ba88db5
Remove unused import
dwnusbaum Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
import jenkins.util.SystemProperties;
import jenkins.util.Timer;
import org.jenkinsci.plugins.workflow.FilePathUtils;
import org.jenkinsci.plugins.workflow.actions.TimingAction;
import org.jenkinsci.plugins.workflow.flow.BlockableResume;
import org.jenkinsci.plugins.workflow.flow.DurabilityHintProvider;
import org.jenkinsci.plugins.workflow.flow.FlowCopier;
Expand Down Expand Up @@ -1087,10 +1086,6 @@ private final class FailOnLoadListener implements GraphListener {

private final class GraphL implements GraphListener {
@Override public void onNewHead(FlowNode node) {
if (node.getPersistentAction(TimingAction.class) == null) {
node.addAction(new TimingAction());
}

FlowExecution exec = getExecution();
if (node instanceof FlowEndNode) {
finish(((FlowEndNode) node).getResult(), exec != null ? exec.getCauseOfFailure() : null);
Expand Down