Split WorkflowRun.GraphL in two and use new GraphListener.ordinal method to improve listener ordering - #547
Closed
dwnusbaum wants to merge 2 commits into
Closed
Split WorkflowRun.GraphL in two and use new GraphListener.ordinal method to improve listener ordering#547dwnusbaum wants to merge 2 commits into
WorkflowRun.GraphL in two and use new GraphListener.ordinal method to improve listener ordering#547dwnusbaum wants to merge 2 commits into
Conversation
…hod to improve listener ordering
dwnusbaum
commented
Jul 1, 2025
Comment on lines
1092
to
1094
| if (node.getPersistentAction(TimingAction.class) == null) { | ||
| node.addAction(new TimingAction()); | ||
| } |
Member
Author
There was a problem hiding this comment.
I tried to write a test for the new logic and noticed that this seems to be largely redundant because of FlowHead.setNewHead. I think the if was added in #75 to prevent duplicate actions after jenkinsci/workflow-cps-plugin#188 started adding TimingAction in FlowHead (merged same day, but the former depends on the latter). Maybe though the whole block should be deleted here instead. I'm not sure if there's a case where it does anything.
6 tasks
Member
Author
|
Unnecessary as of jenkinsci/workflow-cps-plugin@4241907 in jenkinsci/workflow-cps-plugin#1052. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jenkinsci/workflow-cps-plugin#1052 and jenkinsci/workflow-api-plugin#410.
Testing done
Submitter checklist