refactor: resume a paused build when it is aborted - #1819
Open
bianbbc87 wants to merge 1 commit into
Open
Conversation
Signed-off-by: EunJiJung <bianbbc87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe PR
CpsFlowExecution.interrupt()delivers aFlowInterruptedExceptioninto the CPS threads, but propagating it runningcatch/finallyand ending the program requiresCpsThreadGroup.run(), whichscheduleRun()skips while paused.So if the build stayed paused, the abort was delivered but never completed until someone unpaused it manually or used Hard Kill.
This just adds one rule on top aborting a build clears the pause. The pause gate itself is untouched.
Quiet-down pauses and
CpsBodyExecution.cancel()(parallel failFast) are out of scope.Fixes #1818
Testing done
New test
CpsFlowExecutionTest.abortWhilePausedpauses a build atsemaphore, aborts it, and checks it finishes. Pipeline istry {semaphore 'wait'} finally {echo 'cleaning up'}.Before fix
After fix
Expected result
the abort completes instead of hanging,
finallystill runs, and the build ends as ABORTED.Submitter checklist