Skip to content

Prevent winstone cleanup from removing files outside webroot #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpan-pramanik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent winstone cleanup from removing files outside webroot #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/main/java/winstone/HostConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,17 @@
}

private void deleteRecursive(File dir) {
File[] children = dir.listFiles();
if (children != null) {
for (File child : children) {
deleteRecursive(child);
try {
if (!Files.isSymbolicLink(dir.toPath())) {

Check warning on line 360 in src/main/java/winstone/HostConfiguration.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 360 is only partially covered, one branch is missing
File[] children = dir.listFiles();
if (children != null) {
for (File child : children) {
deleteRecursive(child);
}
Comment on lines +360 to +365
}
Comment on lines +359 to +366
}
} catch (Exception ex) {

Check warning on line 368 in src/main/java/winstone/HostConfiguration.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 368 is not covered by tests
// Ignore path exceptions here; they will be handled by deleteIfExists below
}
try {
Files.deleteIfExists(dir.toPath());
Expand Down