Remove obsolete incremental config - #3382
Conversation
| @@ -1,3 +1,2 @@ | |||
| -Dchangelist.format=%d.v%s | |||
| -Pconsume-incrementals | |||
There was a problem hiding this comment.
either enable this profile locally when needed, or for CI add a marker file to enable it along with the incremental dependency that is required.
| <repositories> | ||
| <repository> | ||
| <id>repo.jenkins-ci.org</id> | ||
| <url>https://repo.jenkins-ci.org/public/</url> | ||
| </repository> |
There was a problem hiding this comment.
set in the parent which should be availble locally via the default <relativePath>../pom.xml</relativePath>
| <repository> | ||
| <id>incrementals.jenkins-ci.org</id> | ||
| <url>https://repo.jenkins-ci.org/incrementals/</url> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
remove the incremental repo -> #3368 (comment)
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>repo.jenkins-ci.org</id> | ||
| <url>https://repo.jenkins-ci.org/public/</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> |
There was a problem hiding this comment.
set in the parent which should be availble locally via the default <relativePath>../pom.xml</relativePath>
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>warnings-ng-ui-tests</artifactId> | ||
| <version>UNVERSIONED</version> | ||
| <version>UNVERSIONED-SNAPSHOT</version> |
There was a problem hiding this comment.
given the source code changes here always use a SNAPSHOT version never a release version.
| <repository> | ||
| <id>incrementals.jenkins-ci.org</id> | ||
| <url>https://repo.jenkins-ci.org/incrementals/</url> | ||
| </repository> |
There was a problem hiding this comment.
not sure exactly how your GH actions are setup - but should use something similar to the stock buildPlugin and a marker file to enable the consume-incrementals profile.
| <profile> | ||
| <id>consume-incrementals</id> | ||
| </profile> | ||
| <profile> | ||
| <id>might-produce-incrementals</id> | ||
| </profile> |
There was a problem hiding this comment.
overrode the profiles so they where a NO-OP
|
artifactory is currently down, so the build failures are not realistic |
Testing done
mvn clean package -DforkCount=6Submitter checklist