feature-hide N/A tests configurable - #161
Conversation
|
CI failure appears infrastructure-related, not code-related: |
|
CI still fails due to infrastructure, not code changes. |
There was a problem hiding this comment.
Pull request overview
Adds a new user-configurable threshold to hide tests that have N/A results across recent builds, reducing noise in the Test Results Analyzer report and improving readability over time.
Changes:
- Extend
JsTreeUtil#getJsTree(...)to optionally omit tests (and now-empty parent nodes) based on an N/A threshold. - Add UI inputs for the new threshold in both global configuration and the report page, and pass it via
UserConfig. - Add/adjust unit tests for the new
JsTreeUtilbehavior and update call sites for the new method signature.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/jenkinsci/plugins/testresultsanalyzer/JsTreeUtilTest.java | Updates existing tests for the new getJsTree signature and adds coverage for hiding behavior. |
| src/main/webapp/js/testresult.js | Includes the new threshold value in the per-page user configuration payload. |
| src/main/resources/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension/global.jelly | Adds a global configuration field for the N/A hiding threshold. |
| src/main/resources/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerAction/index.jelly | Adds a per-page numeric input for the threshold in the report UI. |
| src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerExtension.java | Persists the new global config value and adds server-side validation hook. |
| src/main/java/org/jenkinsci/plugins/testresultsanalyzer/TestResultsAnalyzerAction.java | Parses/clamps the threshold from UserConfig, falling back to the global default, and passes it into JsTreeUtil. |
| src/main/java/org/jenkinsci/plugins/testresultsanalyzer/JsTreeUtil.java | Implements filtering/hiding logic based on N/A threshold while building the tree JSON. |
| src/main/java/org/jenkinsci/plugins/testresultsanalyzer/config/UserConfig.java | Extends user config model/binding to carry the new threshold value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@MarkEWaite Can you have a look again? |
|
@MarkEWaite Hello Mark, can you review again:) |
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
left a comment
There was a problem hiding this comment.
@pfeilh I'm not a primary maintainer of the plugin. I reviewed the initial changes because I had a few minutes to do so. I don't have the capacity right now to complete a full review. That will need to be done by other maintainers.
|
For the others maintainers. I tested this feature locally in a separate Jenkins instance and the N/A threshold behavior works as expected. The implementation looks correct for me and the checks are green. From my side this is ready for review. |
|
Sorry @MarkEWaite, I wait for the other maintainers;) Thanks for now |
Thanks for being understanding that I'm not the right person to do the detailed review. |
https://issues.jenkins.io/browse/JENKINS-75315?jql=resolution%20is%20EMPTY%20and%20component%3D19327
See #XXXXX
Testing done
Proposed upgrade guidelines
N/A
Submitter checklist
@NoExternalUse. In case it is used by non java code theUsed by {@code <panel>.jelly}Javadocs are annotated.evalto ease the future introduction of Content Security Policy (CSP) directives (see documentation).Maintainer checklist
Before the changes are marked as
ready-for-merge: