chore: Address scanner-version-testing review feedback#163
Merged
Conversation
Make the newest and oldest fixture parse tests symmetric: both fixtures are committed, so the oldest test no longer skips via assumeTrue while the newest hard-fails — a missing fixture is a real failure for both. Document that the scanner recipes assume GNU sed/date and that regenerating fixtures (and thus `just update`) needs network access and SECURE_API_TOKEN, while normal builds and the test suite run against the committed fixtures without either.
tembleking
requested review from
Jujuyeh,
airadier,
alecron and
mateobur
as code owners
July 9, 2026 11:18
The justfile `scanner` recipes need GNU sed/date/grep plus curl, jq and gzip; rather than just documenting the assumption, add them to the devShell so they are available out of the box (notably GNU sed/date on macOS, where the system defaults are BSD).
mateobur
approved these changes
Jul 9, 2026
mateobur
left a comment
mateobur
left a comment
Collaborator
There was a problem hiding this comment.
Nice cleanup. Documenting the scanner tooling and wiring it into the Nix devshell closes the gap, and dropping the silent skip means a missing oldest fixture now fails loudly with a clear pointer to regenerate it. Looks good to merge.
tembleking
changed the title
tembleking
enabled auto-merge (squash)
July 9, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #162.
Make the newest and oldest fixture parse tests symmetric. Both fixtures are checked in, so the oldest test no longer skips via
assumeTruewhile the newest hard-fails — a missing fixture is a genuine failure for both, and the deadoldestScannerFixtureAvailable()helper is gone.Provide the tooling the
scannerjustfile recipes depend on via the Nix devshell — GNUsed/date/grep,curl,jqandgzip— instead of just assuming it is present (notably GNUsed/dateon macOS, where the system defaults are BSD).Document in CONTRIBUTING that regenerating the checked-in fixtures — and therefore
just update— needs network access andSECURE_API_TOKEN, whereas a normal build and the test suite run against the committed fixtures without either.