Skip to content

Move from RootAction to View Action - #124

Closed
janfaracik wants to merge 1 commit into
jenkinsci:masterfrom
janfaracik:move-from-root-action
Closed

Move from RootAction to View Action#124
janfaracik wants to merge 1 commit into
jenkinsci:masterfrom
janfaracik:move-from-root-action

Conversation

@janfaracik

@janfaracik janfaracik commented May 22, 2025

Copy link
Copy Markdown
Member

This PR changes the Purge build queue from being a root action to being a view action instead. Root actions have been moved to the header as of jenkinsci/jenkins#10245, and in that move the ability to have custom action.jelly files has been removed - this is in an effort to enforce consistency between root actions.

As a result, this plugin got broken. This PR aims to resolve that by moving the action from a RootAction to a plain ol' Action - so it'll still appear on views as expected, but it won't appear in the header.

Requires jenkinsci/jenkins#10676 to show the view action with the new header.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jtnord

jtnord commented Jun 19, 2025

Copy link
Copy Markdown
Member

and in that move the ability to have custom action.jelly files has been removed - this is in an effort to enforce consistency between root actions.

is a bug not a feature JENKINS-75683 which is addressed in jenkinsci/jenkins#10678 (which reveals an existing bug in this plugin -> #126 )

@jtnord

jtnord commented Jul 2, 2025

Copy link
Copy Markdown
Member

Obsolete now that #126 is merged?
Additionally actions that affect Jenkins globally rather then just the current context should IMO always be RootActions and appear in the header. Only things that perform something in the context of the current ModelObject should be a view action.

@janfaracik janfaracik closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants