Move from RootAction to View Action - #124
Closed
janfaracik wants to merge 1 commit into
Closed
Conversation
Member
is a bug not a feature JENKINS-75683 which is addressed in jenkinsci/jenkins#10678 (which reveals an existing bug in this plugin -> #126 ) |
6 tasks
Member
|
Obsolete now that #126 is merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the Purge build queue from being a root action to being a view action instead. Root actions have been moved to the header as of jenkinsci/jenkins#10245, and in that move the ability to have custom
action.jellyfiles has been removed - this is in an effort to enforce consistency between root actions.As a result, this plugin got broken. This PR aims to resolve that by moving the action from a RootAction to a plain ol' Action - so it'll still appear on views as expected, but it won't appear in the header.
Requires jenkinsci/jenkins#10676 to show the view action with the new header.
Testing done
Submitter checklist