Remove commons-lang2 usages - #348
Open
gbhat618 wants to merge 3 commits into
Open
Conversation
gbhat618
commented
Jul 23, 2026
Comment on lines
-53
to
-62
| import org.apache.commons.lang.StringUtils; | ||
| import org.apache.http.concurrent.BasicFuture; | ||
|
|
||
| import java.text.SimpleDateFormat; | ||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.Date; | ||
| import java.util.List; | ||
| import java.util.concurrent.ExecutionException; | ||
|
|
gbhat618
marked this pull request as ready for review
July 23, 2026 07:50
4 tasks
Author
|
/label developer to get a release to test and update in jenkinsci/bom#6234 |
jtnord
reviewed
Jul 24, 2026
gbhat618
commented
Jul 27, 2026
| CreateStackRequest req = new CreateStackRequest(); | ||
| req.withStackName(this.stack).withCapabilities(Capability.CAPABILITY_IAM, Capability.CAPABILITY_NAMED_IAM, Capability.CAPABILITY_AUTO_EXPAND).withEnableTerminationProtection(enableTerminationProtection); | ||
| req.withTemplateBody(templateBody).withTemplateURL(templateUrl).withParameters(params).withTags(tags).withNotificationARNs(notificationARNs) | ||
| .withTimeoutInMinutes(pollConfiguration.getTimeout() == null ? null : (int) pollConfiguration.getTimeout().toMinutes()) |
Author
There was a problem hiding this comment.
pollConfiguration.getTimeout() is @NonNull no need of null check
jtnord
approved these changes
Jul 27, 2026
Author
|
Hi @hoegertn can you help review. Once the jenkins-core drops commons-lang2 there will be errors here, so preparing for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for commons-lang2 removal jenkinsci/jenkins#26105, usages are simple here so use JDK apis directly.
This PR builds on top of #344
Testing
mvn compileafter ban commons-lang2.