Skip to content

Ban Commons Lang 2 - #1213

Merged
kuisathaverat merged 2 commits into
jenkinsci:mainfrom
alecharp:chore/migrate-commons-lang
Jan 16, 2026
Merged

Ban Commons Lang 2#1213
kuisathaverat merged 2 commits into
jenkinsci:mainfrom
alecharp:chore/migrate-commons-lang

Conversation

@alecharp

Copy link
Copy Markdown
Member

This is an undeclared library, coming from core, which we need to remove.

See jenkinsci/jenkins#26105 and jenkinsci/bom#6234

Testing done

mvn test-compile without problem. Relying on CI for the rest.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

This is an undeclared library, coming from core, which we need to remove
alecharp added a commit to alecharp/bom that referenced this pull request Jan 14, 2026
@alecharp

Copy link
Copy Markdown
Member Author

cc @jenkinsci/opentelemetry-plugin-developers

@kuisathaverat
kuisathaverat merged commit 56eb783 into jenkinsci:main Jan 16, 2026
17 checks passed
@alecharp

alecharp commented Jan 16, 2026

Copy link
Copy Markdown
Member Author

A release is needed. internal label does not trigger a release per CD. developer would have.

@kuisathaverat

Copy link
Copy Markdown
Contributor

A release is needed. internal label does not trigger a release per CD. developer would have.

I know it, I do not think the change is worth a release.

@alecharp

Copy link
Copy Markdown
Member Author

I know it, I do not think the change is worth a release.

without a release, it means we cannot plan to remove completely the library from Jenkins Core.

@alecharp
alecharp deleted the chore/migrate-commons-lang branch January 16, 2026 12:32
Comment thread pom.xml
Comment on lines +156 to +159
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>commons-lang3-api</artifactId>
</dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecharp Spotless remove this dependency when you run mvn spotless:apply that means it is already provided, would this change in the BOM?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecharp alecharp Jan 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't remove it, it moved it, no?

@alecharp alecharp mentioned this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants