Use the standard OIDC picture claim for user avatars by itsvshreyas · Pull Request #782 · jenkinsci/oic-auth-plugin

itsvshreyas · 2026-07-24T15:09:53Z

Use the standard OIDC picture claim for user avatars

Keep the standard picture claim as the default avatar claim for OIDC providers.
Add configurable avatarFieldName support for providers exposing the avatar URL through another claim.
Add Microsoft Entra ID support by fetching the user's profile photo from Microsoft Graph server-side.
Request the User.Read scope automatically for Microsoft Entra issuers when it is not already configured.
Use the OAuth bearer token only for the server-side Graph request; never expose it to the browser.
Serve fetched Graph images through Jenkins using the user's /oic-avatar/image endpoint.
Preserve direct browser-accessible avatar URLs for non-Graph OIDC providers.
Fall back to the default Jenkins avatar when no valid avatar is available.
Add documentation for Microsoft Entra configuration and required delegated Graph permissions.

Fixes: #709

Testing done

Added tests for successful Microsoft Graph avatar fetching.
Added tests verifying the Graph Authorization and Accept headers.
Added tests for missing access tokens.
Added tests for non-successful, empty, oversized, and non-image Graph responses.
Added tests for Graph connection failures and missing content types.
Added tests for Base64 data URL generation and Jenkins avatar endpoint serving.
Added tests for valid, invalid, empty, and null avatar values.
Added tests for direct avatar URLs.
Added tests for Microsoft Entra issuer detection and automatic User.Read scope handling.
Added tests for Entra users without a picture claim.
Updated Configuration as Code tests and fixtures.
All affected tests pass with 0 failures:
- MicrosoftGraphAvatarFetcherTest: 9 tests, 0 failures
- OicAvatarPropertyTest: 4 tests, 0 failures
- OicSecurityRealmTest: 15 tests, 0 failures
- PluginTest: 40 tests, 0 failures, 2 skipped
Full Maven test suite passes:
- 185 tests, 0 failures, 0 errors, 2 skipped
JaCoCo coverage for MicrosoftGraphAvatarFetcher:
- Instructions: 100%
- Lines: 100%
- Branches: 100%
- Methods: 100%
- Classes: 100%
mvn spotless:apply completed successfully.
Manually validated plugin installation and avatar rendering in Jenkins.

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch and not your main branch.
Ensure that the pull request title represents the desired changelog entry.
Please describe what you did.
Link to relevant issues or Jira.
Link to relevant pull requests, especially upstream and downstream changes.
Ensure that you have provided tests demonstrating that the feature works or the issue is fixed.

… URLs - Introduced and properties in OIC Security Realm. - Updated configuration files and documentation to reflect new avatar settings. - Implemented tests for avatar URL handling, including Microsoft Graph integration. Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

…plTest, OicSecurityRealmTest, and PluginTest Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas · 2026-07-25T09:43:41Z

Hi @michael-doubez, This PR is completely ready for review.

itsvshreyas · 2026-07-30T10:05:29Z

Hi @michael-doubez , Could you please review it? It will close the issue #709.

itsvshreyas · 2026-08-07T07:12:51Z

Hi @michael-doubez , Could you please review this PR? It will close the issue #709.

michael-doubez · 2026-08-07T08:42:32Z

@itsvshreyas hello. I don t have access to a computer right now and my smartphone is not a good place for a code review

I should be back to civilisation next week.

itsvshreyas · 2026-08-10T10:01:05Z

@itsvshreyas hello. I don t have access to a computer right now and my smartphone is not a good place for a code review

I should be back to civilisation next week.

Hi @michael-doubez ,
Hope you're doing well. I wanted to follow up regarding the plugin review we discussed. I've completed testing of the latest changes, and everything looks good from my side, particularly the image loading behavior. Whenever you get a chance this week, I'd appreciate your review.

Thank you for your time!

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas · 2026-08-10T15:03:00Z

Hi @michael-doubez, As an update, I have also added commits to cover the remaining three lines for code coverage. Everything is now complete and ready for review.

itsvshreyas · 2026-08-13T13:30:27Z

Hi @michael-doubez , I just wanted to check if you are back and would be possible to review this today? Thanks!

codecov · 2026-08-14T11:55:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.46%. Comparing base (f202e42) to head (400c18e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #782      +/-   ##
============================================
+ Coverage     76.06%   76.46%   +0.40%     
- Complexity      325      335      +10     
============================================
  Files            33       33              
  Lines          1291     1313      +22     
  Branches        178      181       +3     
============================================
+ Hits            982     1004      +22     
  Misses          227      227              
  Partials         82       82

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

itsvshreyas · 2026-08-14T12:06:41Z

Hi @olamy / @michael-doubez , Code Coverage tests have been passed. Could you please review and approve if everything is okay? Thanks!

itsvshreyas · 2026-08-17T05:37:25Z

Hi @olamy / @michael-doubez , Code Coverage tests have been passed. Could you please review and approve if everything is okay? Thanks!

Hi @olamy / @michael-doubez / @timja / @jtnord , Code Coverage has been completed and all have passed. Could you please review and approve if everything is good? Thanks!

timja · 2026-08-17T07:58:21Z

Not a maintainer, if you want the Entra avatars to work you can take a look at this code:
jenkinsci/azure-ad-plugin#658

timja · 2026-08-17T07:59:48Z

cc @mjmbischoff too

itsvshreyas · 2026-08-17T08:02:36Z

Not a maintainer, if you want the Entra avatars to work you can take a look at this code: jenkinsci/azure-ad-plugin#658

Hi @timja, Thank you for that PR reference. I got it working in this PR for oic-auth. I made Microsoft Graph optional and it will be used only if required.

timja · 2026-08-17T08:05:01Z

Not a maintainer, if you want the Entra avatars to work you can take a look at this code: jenkinsci/azure-ad-plugin#658

Hi @timja, Thank you for that PR reference. I got it working in this PR for oic-auth. I made Microsoft Graph optional and it will be used only if required.

The PR description doesn't seem to reflect that:

Blocks Microsoft Graph photo URLs by default to prevent broken avatar images.

I would expect it to work out of the box without additional configuration or checkboxes.

jonesbusy · 2026-08-17T08:26:37Z

Noting: #523 (comment)

No idea about Entra avatar. But if the picture claim URL require authentication, it will not work with current implementation.

Curious, why not using azure-ad-plugin?

A checkbox look silly

I'm not a maintainer of this plugin

jtnord · 2026-08-17T08:47:41Z

Please avoid provider specific workarounds in this plugin, the OIDC spec has a spec so no specifics for any provider should not be needed.
Additionally picture is a standard claim in user profile so I do not believe this should be configurable.

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas · 2026-08-17T09:53:40Z

Thank you for all your feedback. I have got a working version which does not require any field selection. I will update the PR shortly (code/PR title and description) to reflect those changes. That will resolve broken image issue.

itsvshreyas · 2026-08-17T09:55:52Z

Please avoid provider specific workarounds in this plugin, the OIDC spec has a spec so no specifics for any provider should not be needed.
Additionally picture is a standard claim in user profile so I do not believe this should be configurable.

Hi @jtnord, Thanks for pointing this out. I agree that provider-specific Microsoft Graph handling does not belong in the generic OIDC plugin, and that picture is already a standard OpenID Connect claim.

The original change was intended to address providers that expose protected image URLs, but that should not be solved with Entra-specific logic here. I have simplified the implementation to use the standard picture claim directly and remove the provider-specific Graph handling and claim configuration. This PR will be updated shortly.

…pertyAdd unit tests for Microsoft Graph avatar fetching and OIC avatar property Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

… handling Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

…hing Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

…ityRealm Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas · 2026-08-24T15:15:42Z

This still contains Microsoft specifics, and still allows configuration of something that is a standard claim. Additionally it introduces a new security issue.

Hi @jtnord , Agreed. We initially tried relying only on the standard OIDC picture claim, but with Microsoft Entra ID the claim may be absent or may contain a Microsoft Graph photo URL that the browser cannot access without a bearer token. To support Entra deployments without making Microsoft-specific behavior the default, we added useMicrosoftGraphForAvatar, which is disabled by default. When enabled, the plugin fetches the photo server-side from Microsoft Graph using the access token; otherwise, it uses only the standard OIDC picture claim. Please review the latest changes and approve the PR if everything looks good now.

jtnord · 2026-08-24T17:57:59Z

This still contains Microsoft specifics, and still allows configuration of something that is a standard claim. Additionally it introduces a new security issue.

Hi @jtnord , Agreed. We initially tried relying only on the standard OIDC picture claim, but with Microsoft Entra ID the claim may be absent or may contain a Microsoft Graph photo URL that the browser cannot access without a bearer token. To support Entra deployments without making Microsoft-specific behavior the default, we added useMicrosoftGraphForAvatar, which is disabled by default. When enabled, the plugin fetches the photo server-side from Microsoft Graph using the access token; otherwise, it uses only the standard OIDC picture claim. Please review the latest changes and approve the PR if everything looks good now.

So I am happy to support data: URLs for avatars in this plugin as its generic, or adding an ability to skip avatars (for the case they would all be private, or even attempt to download them locally and then serve them).
Howevever for MS specifics if you need MS specific functionality why would you not use the Microsoft Entra ID plugin?

The problem is not this one implementation, it is that this opens the way for every implementation that does something to have provider specific code, and then the plugin config becomes a spaghetti mess of configuration options that mean nothing to most people (as well as the maintenance burden)

jtnord · 2026-08-24T18:04:15Z

    }

+    public void doImage(StaplerResponse2 response) throws IOException {
+        AvatarData data = avatarImage == null ? null : parseDataUrl(avatarImage.url);


just wondering how large these can be (and if they actually need to be in memory)?

5MB looking at MAX_SIZE. this is information that would be loaded/persisted in the User object and on a busy system with 100s of active users that could be quite large.

Could we save the image to disk in the users folder, and then use the optimized serveFile API?

Hi @jtnord , I’ve updated the implementation so that data URL avatars are validated against the existing 5 MB limit, written to the user’s folder as oic-avatar, and represented in OicAvatarProperty only by their filename and content type rather than by the image data itself. Requests now stream the image from disk using Stapler’s optimized serveFile API, while regular external avatar URLs continue to work as before. I also added test coverage for persisting the image and serving it through serveFile; the focused avatar tests and full test suite pass.

itsvshreyas · 2026-08-25T02:04:21Z

So I am happy to support data: URLs for avatars in this plugin as its generic, or adding an ability to skip avatars (for the case they would all be private, or even attempt to download them locally and then serve them). Howevever for MS specifics if you need MS specific functionality why would you not use the Microsoft Entra ID plugin?

The problem is not this one implementation, it is that this opens the way for every implementation that does something to have provider specific code, and then the plugin config becomes a spaghetti mess of configuration options that mean nothing to most people (as well as the maintenance burden)

Hi @jtnord ,
Thanks, I agree that provider-specific behavior should not become the default design for this plugin.

The solution in this PR keeps the standard OIDC behavior as the default. The plugin uses the standard picture claim when it contains a normal URL or a supported data: URL. Data URLs are stored and served by Jenkins, so the browser does not need direct access to the image. If the claim is absent or unusable, the plugin leaves the OIC avatar unset and Jenkins can use its normal default avatar. In our SAML setup, that default CloudBees avatar loads correctly; previously, the invalid avatar URL returned by the identity provider resulted in a broken image instead.

In our Entra-based setup, the value returned for the avatar was either missing or a Microsoft Graph photo URL. Although that URL looks valid, the browser cannot load it because the request requires a bearer token. The opt-in useMicrosoftGraphForAvatar setting addresses that specific deployment: Jenkins fetches the photo server-side with the access token and stores it as a data: URL. It is disabled by default, so it does not add Microsoft-specific behavior for normal OIDC providers or alter existing configurations.

This gives us a working avatar for Entra deployments while preserving the generic OIDC behavior and the normal Jenkins fallback for everyone else. The latest changes also validate supported image types and sizes before serving images locally. The opt-in path requires the appropriate Microsoft Graph permission, such as delegated User.Read.

…nd retrieval Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

… test Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

…ptions more clearly Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

…pertyTest Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas · 2026-08-25T08:42:22Z

Hi @jtnord , This is good for review now. All changes based on your feedback has been incorporated. Could you please review now? Thanks!

jtnord · 2026-08-25T09:08:17Z

f the claim is absent or unusable, the plugin leaves the OIC avatar unset and Jenkins can use its normal default avatar. In our SAML setup, that default CloudBees avatar loads correctly; previously, the invalid avatar URL returned by the identity provider resulted in a broken image instead.

If you are using CloudBees CI, I would recommend that you raise a support ticket with them about the broken behaviour you are seeing.

itsvshreyas · 2026-08-25T09:45:48Z

f the claim is absent or unusable, the plugin leaves the OIC avatar unset and Jenkins can use its normal default avatar. In our SAML setup, that default CloudBees avatar loads correctly; previously, the invalid avatar URL returned by the identity provider resulted in a broken image instead.

If you are using CloudBees CI, I would recommend that you raise a support ticket with them about the broken behaviour you are seeing.

Hi @jtnord , We had already brought this issue to attention and were informed that the root cause was associated with the plugin. Following that discussion, we decided to contribute a solution through this repository. We also observed similar reports from other users (e.g., #709), indicating that this is a recurring scenario rather than an isolated case. We believe having this solution in place would help others facing the same challenge.

We would appreciate your review and approval of this proposed change.

itsvshreyas · 2026-09-01T04:29:39Z

Hi @jtnord , Is there anything else that needs to be done as part of this PR? Happy to make if any further changes required. Thanks!

jtnord · 2026-09-02T13:27:20Z

Hi @jtnord , Is there anything else that needs to be done as part of this PR? Happy to make if any further changes required. Thanks!

Its still containing MS specifics and as I have said these should not be in this plugin.

I have filed #793 that should fix the actual broken avatar (just set the Do Not Use Avatars policy) and lays the groundwork for an implementation that would pull images and serve them from Jenkins (and does not cause cognitive overload in the UI due to a myriad of provider specific checkboxes). (~~I have this locally but have not pushed this~~ jtnord#5 shows some claude vibe coded code for what this may look like).

As the Picture URL returned by O365 is the MS graph URL - all that is needed is an implementation that fetches the URL using the access token (and this has zero MS sepecific). NB I would start on the implementaion that fectes without authentication so that it is slightly easier to ensure that no security issues are introduced.

- Added OicAvatarFetcher class to download images from OIDC providers using access tokens. - Updated OicAvatarProperty to store and serve avatars from Jenkins instead of relying on external URLs. - Refactored OicSecurityRealm to support configuration for serving avatars from Jenkins. - Removed MicrosoftGraphAvatarFetcher and related configurations, consolidating avatar fetching logic. - Updated configuration files and UI to reflect changes in avatar handling. - Added tests for OicAvatarFetcher and updated existing tests for OicAvatarProperty and OicSecurityRealm. Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

…sts for missing content type and avatar file absence Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas · 2026-09-02T17:18:02Z

Hi @jtnord , Is there anything else that needs to be done as part of this PR? Happy to make if any further changes required. Thanks!

Its still containing MS specifics and as I have said these should not be in this plugin.

I have filed #793 that should fix the actual broken avatar (just set the Do Not Use Avatars policy) and lays the groundwork for an implementation that would pull images and serve them from Jenkins (and does not cause cognitive overload in the UI due to a myriad of provider specific checkboxes). (~~I have this locally but have not pushed this~~ jtnord#5 shows some claude vibe coded code for what this may look like).

As the Picture URL returned by O365 is the MS graph URL - all that is needed is an implementation that fetches the URL using the access token (and this has zero MS sepecific). NB I would start on the implementaion that fectes without authentication so that it is slightly easier to ensure that no security issues are introduced.

Hi @jtnord , Thanks, I've reworked this so there's nothing Microsoft-specific left. Could you please re-review the changes? Please let me know if further changes required. Thanks!

itsvshreyas · 2026-09-16T12:04:23Z

Hi @jtnord , All mentioned changes have been completed. Could you please re-review this? Thanks!

itsvshreyas · 2026-09-30T05:24:59Z

Hi @jtnord , All mentioned changes have been completed. Could you please re-review this? Thanks!

jtnord · 2026-09-30T13:41:52Z

Hi @jtnord , Is there anything else that needs to be done as part of this PR? Happy to make if any further changes required. Thanks!

Its still containing MS specifics and as I have said these should not be in this plugin.
I have filed #793 that should fix the actual broken avatar (just set the Do Not Use Avatars policy) and lays the groundwork for an implementation that would pull images and serve them from Jenkins (and does not cause cognitive overload in the UI due to a myriad of provider specific checkboxes). (~~I have this locally but have not pushed this~~ jtnord#5 shows some claude vibe coded code for what this may look like).
As the Picture URL returned by O365 is the MS graph URL - all that is needed is an implementation that fetches the URL using the access token (and this has zero MS sepecific). NB I would start on the implementaion that fectes without authentication so that it is slightly easier to ensure that no security issues are introduced.

Hi @jtnord , Thanks, I've reworked this so there's nothing Microsoft-specific left. Could you please re-review the changes? Please let me know if further changes required. Thanks!

But you have not addressed that this is an inflexible boolean value, and ignored the referenced pull requests?

FWIW, in CloudBees CI the avatars would still not be displayed in controllers when using single sign on.

itsvshreyas requested a review from a team as a code owner July 24, 2026 15:09

itsvshreyas mentioned this pull request Jul 24, 2026

Make avatar claim configurable #709

Closed

Refactor test methods for consistency and readability in DescriptorIm…

da351b0

…plTest, OicSecurityRealmTest, and PluginTest Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas added 2 commits August 10, 2026 19:54

Fixed coverage issue

13258d4

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

fixed code coverage

400c18e

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas added 2 commits August 17, 2026 15:04

Implement Microsoft Graph avatar support and refactor related properties

fda8a15

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Document Microsoft Entra avatar configuration

f8dbef7

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas changed the title ~~Make avatar claim configurable and block Microsoft Graph avatar URLs by default~~ Use the standard OIDC picture claim for user avatars Aug 17, 2026

itsvshreyas added 3 commits August 17, 2026 15:48

Add unit tests for Microsoft Graph avatar fetching and OIC avatar pro…

2359c1f

…pertyAdd unit tests for Microsoft Graph avatar fetching and OIC avatar property Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Add tests for Microsoft Graph avatar fetching and OIC avatar property…

aa51468

… handling Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Cover remaining Graph avatar fetcher branches

9e68f89

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas added 2 commits August 24, 2026 19:58

Add avatar URL sanitization and tests for Microsoft Graph avatar fetc…

c77ccab

…hing Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Refactor test formatting for MicrosoftGraphAvatarFetcher and OicSecur…

66bd5b5

…ityRealm Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas requested a review from jtnord August 24, 2026 14:59

Add support for fetching avatars from Microsoft Graph for Entra ID users

627d6c5

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

jtnord reviewed Aug 24, 2026

View reviewed changes

Enhance OIC Avatar Property to support user-specific avatar storage a…

87bc0e5

…nd retrieval Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas requested a review from jtnord August 25, 2026 03:10

itsvshreyas added 5 commits August 25, 2026 09:01

Refactor OicAvatarPropertyTest for improved readability and formatting

9d15437

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Add null check for user folder in OicAvatarProperty and corresponding…

2db00d6

… test Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Add test to handle file serving failures in OicAvatarProperty

cf124cb

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Refactor OicAvatarPropertyTest to improve readability and handle exce…

f601a1e

…ptions more clearly Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Add null check for user in getAvatarUrlForUser method in OicAvatarPro…

459bea8

…pertyTest Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

jtnord self-assigned this Aug 28, 2026

jtnord reviewed Sep 2, 2026

View reviewed changes

Comment thread src/main/java/org/jenkinsci/plugins/oic/OicSecurityRealm.java Outdated

Comment thread src/main/java/org/jenkinsci/plugins/oic/MicrosoftGraphAvatarFetcher.java Outdated

Comment thread src/main/java/org/jenkinsci/plugins/oic/OicSecurityRealm.java Outdated

itsvshreyas added 3 commits September 2, 2026 20:41

Enhance OIC Avatar Fetching: Improve inline data URL handling, add te…

82dfba7

…sts for missing content type and avatar file absence Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

Fixed the issue

f8a5919

Signed-off-by: Venkata Shreyas Kabekkodu <venkatashreyas.kabekkodu@fmr.com>

itsvshreyas requested a review from jtnord September 2, 2026 17:18

Conversation

itsvshreyas commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

itsvshreyas commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsvshreyas commented Jul 30, 2026

Uh oh!

itsvshreyas commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-doubez commented Aug 7, 2026

Uh oh!

itsvshreyas commented Aug 10, 2026

Uh oh!

itsvshreyas commented Aug 10, 2026

Uh oh!

itsvshreyas commented Aug 13, 2026

Uh oh!

codecov Bot commented Aug 14, 2026

Codecov Report

Uh oh!

itsvshreyas commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsvshreyas commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Aug 17, 2026

Uh oh!

timja commented Aug 17, 2026

Uh oh!

itsvshreyas commented Aug 17, 2026

Uh oh!

timja commented Aug 17, 2026

Uh oh!

jonesbusy commented Aug 17, 2026

Uh oh!

jtnord commented Aug 17, 2026

Uh oh!

itsvshreyas commented Aug 17, 2026

Uh oh!

itsvshreyas commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsvshreyas commented Aug 24, 2026

Uh oh!

jtnord commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtnord Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itsvshreyas Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

itsvshreyas commented Aug 25, 2026

Uh oh!

itsvshreyas commented Aug 25, 2026

Uh oh!

jtnord commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsvshreyas commented Aug 25, 2026

Uh oh!

itsvshreyas commented Sep 1, 2026

Uh oh!

jtnord commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

itsvshreyas commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itsvshreyas commented Jul 24, 2026 •

edited

Loading

itsvshreyas commented Jul 25, 2026 •

edited

Loading

itsvshreyas commented Aug 7, 2026 •

edited

Loading

itsvshreyas commented Aug 14, 2026 •

edited

Loading

itsvshreyas commented Aug 17, 2026 •

edited

Loading

itsvshreyas commented Aug 17, 2026 •

edited

Loading

jtnord commented Aug 24, 2026 •

edited

Loading

jtnord Aug 24, 2026 •

edited

Loading

jtnord commented Aug 25, 2026 •

edited

Loading

jtnord commented Sep 2, 2026 •

edited

Loading

itsvshreyas commented Sep 2, 2026 •

edited

Loading